HDR -> SDR conversion

These CUDA filters are packaged into DGDecodeNV, which is part of DGDecNV.
User avatar
admin
Posts: 4551
Joined: Thu Sep 09, 2010 3:08 pm

Re: HDR -> SDR conversion

Post by admin »

YV12 is not YUV420P16, though it can be stored that way (8 bits are wasted). The source is 4:2:0 so saving it as 4:4:4 cannot retain extra source detail.

Dion is asking for me to output YUV420P16. I am asking for it to be justified with evidence. Talking about 4:4:4 is not germane to that. Can you output YUV420P16 with 10-bit data from HDRTools?
DAE avatar
Narkyy
Posts: 51
Joined: Thu May 25, 2017 11:51 pm

Re: HDR -> SDR conversion

Post by Narkyy »

In the case of HDRTools, YV12 is YUV420P16. I know it's not usually.
The source is 4:2:0 so I can't grasp how it looks much better when ending in 4:4:4, looks just like madVR but madVR says 4:2:0

As for the banding, I don't think there's a difference between 8 bit and higher as long as there's dithering at the last step.
Compared against everything, banding is just more pronounced with the lighter darks/gamma from DGHDRtoSDR.
User avatar
admin
Posts: 4551
Joined: Thu Sep 09, 2010 3:08 pm

Re: HDR -> SDR conversion

Post by admin »

Narkyy wrote:
Tue Jul 24, 2018 10:55 am
Compared against everything, banding is just more pronounced with the lighter darks/gamma from DGHDRtoSDR.
Where is the evidence of banding? I've asked for evidence and all you guys do is make unsupported claims. Dion just makes useless posts like "I thought this tool outputs 8-bit, am I wrong?"

First you're talking about detail retention now you're talking about banding. Then you talk about 4:4:4 from some other tool. You're starting to irritate me big time.

I hacked a quick version to output the full 10 bits in P16. I open the YV12 and P16 versions in their own VDub2 windows. I see NO difference in detail. I see NO banding in either one. I speculated earlier about the reason but nobody took any notice of it. You seem to have a naive "10-bit good, 8-bit bad" dogma in your heads, and don't think about context.

If you don't substantiate your claims, I'm going to shut down this discussion as it is just FUD at this point. You want to use some other tool, go for it, I don't care. If it's about dithering, then ask for dithering and give a sample that shows that it's needed. Then I will be happy to consider it.
DAE avatar
Dion
Posts: 28
Joined: Sun Dec 04, 2016 12:30 am

Re: HDR -> SDR conversion

Post by Dion »

Thought it was common knowledge that banding is caused by the down conversion from a higher bit master to 8bit?

But anyways.. Here is an example of 8bit vs 16bit vs DGHDRtoSDR. I could not use DGHDRtoSDR in this test for 16bit cause I am sure its going straight to 8bit. That is why I asked if that is what your plugin is doing.

8bit vs 16bit vs DGHDRtoSDR
ImageImageImage

and for good measure..

16bit to 8bit back to 16bit. Info lost...
Image

edit: With Narkyy help was able to get HDRTools to work.. It outputs 16bit Tonemapping correctly no banding either.
Image
User avatar
admin
Posts: 4551
Joined: Thu Sep 09, 2010 3:08 pm

Re: HDR -> SDR conversion

Post by admin »

Now you're talking, thank you. But I need the source sample and all the scripts to be able to replicate it. What did you use for the first two shots? How did you take the screenshots?

If you give me what I need and the banding is eliminated by outputting 16-bits I'll be happy to add that to the filter. But I have to be able to verify that it is working as intended, and not just blindly release something. So, source sample, scripts, and how did you get the screenshots, please.
DAE avatar
Dion
Posts: 28
Joined: Sun Dec 04, 2016 12:30 am

Re: HDR -> SDR conversion

Post by Dion »

https://www.dropbox.com/s/qiwo2v5j6b9c9 ... 2.mkv?dl=1

Make sure you have the latest Avisynth+ otherwise 16bit will error out and display nothing..
https://github.com/pinterf/AviSynthPlus ... /tag/r2728

16 Bit
DGSource("Annihilation-002.dgi", fulldepth=True)
z_Spline36Resize(1920, 1080)
DGHDRtoSDR
DGSource("Annihilation-002.dgi", fulldepth=True)
z_Spline36Resize(1920, 1080)
DGHDRtoSDR(tm="mobius", light=250)
8 Bit
DGSource("Annihilation-002.dgi", fulldepth=True)
z_Spline36Resize(1920, 1080)
ConvertBits(8)
User avatar
admin
Posts: 4551
Joined: Thu Sep 09, 2010 3:08 pm

Re: HDR -> SDR conversion

Post by admin »

Thank you, Dion.

Here is build 1.8, which adds a fulldepth parameter to output 10-bit SDR stored in YUV420P16.

http://rationalqm.us/misc/DGHDRtoSDR_1.8.rar

BTW, you have tm="mobius". That is not valid syntax for build 1.7, so I suppose you used an earlier
version.
DAE avatar
Dion
Posts: 28
Joined: Sun Dec 04, 2016 12:30 am

Re: HDR -> SDR conversion

Post by Dion »

Thanks.. Looks to be working.. :salute:
User avatar
admin
Posts: 4551
Joined: Thu Sep 09, 2010 3:08 pm

Re: HDR -> SDR conversion

Post by admin »

You're welcome. Thank you for pushing for this addition.
DAE avatar
Nginx
Posts: 26
Joined: Fri Mar 23, 2018 12:48 am

Re: HDR -> SDR conversion

Post by Nginx »

Thank you very much ~
User avatar
admin
Posts: 4551
Joined: Thu Sep 09, 2010 3:08 pm

Re: HDR -> SDR conversion

Post by admin »

You're welcome, Nginx.
User avatar
admin
Posts: 4551
Joined: Thu Sep 09, 2010 3:08 pm

Re: HDR -> SDR conversion

Post by admin »

DGHDRtoSDR 1.9 is released. It adds Vapoursynth native support.
DAE avatar
Guest

Re: HDR -> SDR conversion

Post by Guest »

Keeps getting better and better, thank you
DAE avatar
Dion
Posts: 28
Joined: Sun Dec 04, 2016 12:30 am

Re: HDR -> SDR conversion

Post by Dion »

Have you ever considered making an HDR to SDR app for the Nvidia Shield? It has an Nvidia GPU in it and one thing it lacks is an HDR to SDR app that can hook onto Plex or Kodi or some other popular video apps.

Could even charge for it an probably make some decent bank. :D
User avatar
admin
Posts: 4551
Joined: Thu Sep 09, 2010 3:08 pm

Re: HDR -> SDR conversion

Post by admin »

I'll look into it when current projects finish up. Thank you for the suggestion.
DAE avatar
Antikor
Posts: 1
Joined: Thu Sep 20, 2018 4:35 pm

Re: HDR -> SDR conversion

Post by Antikor »

DGTonemap DGHable green and human skin color is not correct, unfortunately, you can add parameters for this. respects
skin color turns green.

|Source
Image Image Image
Image Image Image
Image Image Image
Image Image Image
Image Image Image
Image Image Image
Image Image Image
Image Image Image
Image Image Image
Image Image Image
Image Image Image
Image Image Image
Image Image Image
Image Image Image
Image Image Image
Image Image Image
Image Image Image
Image Image Image
Image Image Image
Image Image Image
DAE avatar
Dion
Posts: 28
Joined: Sun Dec 04, 2016 12:30 am

Re: HDR -> SDR conversion

Post by Dion »

Stark image is from the 1080p bluray.. Not the UHD..

UHD and 1080p BD's do not have the same color.

and on top of that you have never seen a UHD in it's native form.. So you have no idea what Tonemapping is correct. The quest for a perfect SDR tonemap is impossible right now.
DAE avatar
Guest

Re: HDR -> SDR conversion

Post by Guest »

Perfection is a highly improbable result at any time.
All we can hope for is good enough > good > real good > darn, that is good
DGHDRtoSDR is already in the real to darn range
User avatar
hydra3333
Posts: 394
Joined: Wed Oct 06, 2010 3:34 am
Contact:

Re: HDR -> SDR conversion

Post by hydra3333 »

Just a note about the .rar file not opening in 7zip commandline,

Per http://forum.doom9.org/showthread.php?p ... ost1853939 when I try to manually use standalone z7ip to even list the rar file, it fails.

Would it be possible to consider using .zip or something ?
I really do like it here.
User avatar
admin
Posts: 4551
Joined: Thu Sep 09, 2010 3:08 pm

Re: HDR -> SDR conversion

Post by admin »

I'll look into it tomorrow. Thanks for pointing it out. I used to always use ZIP but then I saw lots of people using RAR.
User avatar
alexantr
Posts: 11
Joined: Mon Oct 15, 2018 4:24 pm

Re: HDR -> SDR conversion

Post by alexantr »

Why DGHDRtoSDR has so strange hue?

1. SDR version: https://i.imgur.com/8ns30OO.jpg
2. HDR to SDR with DGTonemap 1.2: https://i.imgur.com/B2jbxdf.jpg
3. HDR to SDR with DGHDRtoSDR 1.10: https://i.imgur.com/zGFdNzF.jpg

avs with DGTonemap:

Code: Select all

loadplugin("D:\Programs\DG\x64\DGDecodeNV.dll")
loadplugin("D:\Programs\DG\x64\DGTonemap.dll")
loadplugin("D:\Programs\DG\x64\avsresize.dll")
SetFilterMTMode("z_ConvertFormat", MT_MULTI_INSTANCE)
DGSource("e:\encode\Coco.dgi", fulldepth=true)
ConvertBits(10)
z_ConvertFormat(pixel_type="RGBPS", colorspace_op="2020ncl:st2084:2020:l=>rgb:linear:2020:l", dither_type="none")
DGReinhard()
z_ConvertFormat(pixel_type="YV12", colorspace_op="rgb:linear:2020:l=>709:709:709:l", dither_type="ordered")
Crop(0, 276, 0, -276)
Spline36Resize(1920, 804)
prefetch(4)
avs with DGHDRtoSDR:

Code: Select all

loadplugin("D:\Programs\DG\x64\DGDecodeNV.dll")
loadplugin("D:\Programs\DG\x64\DGHDRtoSDR.dll")
DGSource("e:\encode\Coco.dgi", fulldepth=true)
Crop(0, 276, 0, -276)
Spline36Resize(1920, 804)
DGHDRtoSDR()
prefetch(6)
Another video:

1. HDR with madVR: https://i.imgur.com/mTlruX1.jpg
2. HDR to SDR with DGTonemap 1.2: https://i.imgur.com/HArYxUt.jpg
3. HDR to SDR with DGHDRtoSDR 1.10: https://i.imgur.com/GaoQ2Go.jpg
User avatar
admin
Posts: 4551
Joined: Thu Sep 09, 2010 3:08 pm

Re: HDR -> SDR conversion

Post by admin »

"strange hue"

Not a really precise formulation but I can look into it if you provide me with an unprocessed source stream sample. I can't do much with JPGs.
User avatar
alexantr
Posts: 11
Joined: Mon Oct 15, 2018 4:24 pm

Re: HDR -> SDR conversion

Post by alexantr »

Please checkout source file: https://mega.nz/#!GsdHmazY!Vo6zfUcpm31E ... HOZbqerSlA

Resulting file after DGHDRtoSDR: https://mega.nz/#!z0MlgaDR!NJlZg76uyf0B ... hDBMeXAcow

Resulting file after DGTonemap: https://mega.nz/#!T8sRhQIZ!4IvY35zNQnwa ... ZK2QLIf7bw

Every my tested video has same problem. I can see almost similar result only after appending Tweak(hue=10).
User avatar
admin
Posts: 4551
Joined: Thu Sep 09, 2010 3:08 pm

Re: HDR -> SDR conversion

Post by admin »

Thanks, I'll look into it.
User avatar
admin
Posts: 4551
Joined: Thu Sep 09, 2010 3:08 pm

Re: HDR -> SDR conversion

Post by admin »

Please try out this version:

http://rationalqm.us/hdr/DGHDRtoSDR_1.11.rar

I added some hue correction for the gamut mapping. We'll never exactly match other solutions. What I am aiming for is reasonable results for most streams and fast processing in CUDA mode.
Post Reply