By garbage skipping do you mean cases were "skip first" is applicable? Like Kino Lorber discs that have 11.010s m2ts clip at the beginning that causes audio/subtitle out-of-sync issue because intro m2ts just consists of the video stream and not the audio/subtitle streams?Rocky wrote: ↑Sun Dec 15, 2019 11:19 amGot the garbage skipping working for CROUPIER. I'd like to ask users whether they think garbage skipping should be optional, i.e., should there be an option to not skip garbage? I always prefer not to have unnecessary options. Can anyone see a use case where it might be desirable to retain content outside the playlist in<-->out times? After this is decided I'll make a release.
BTW, I also enhanced the GUI to do an automatic re-browse when the skip first or skip last boxes are checked/unchecked after an MPLS has been loaded. Much more friendly!
If that's what you mean, then I'd say that it's not always an issue. Sometimes intro/outro content is useful and skipping them is not a good option.
I do agree with you though, I also prefer for there not to be any unnecessary options. I'm not a huge fan of -sf and -sl options. They kind of bloat the program in my view.
As far as understand, this particular issue arises only when m2ts files that in the playlist don't consist of the same streams. That particular situation raises not only the out-of-sync problem, but other problems such as when some of the m2ts files have 640kbps ac3 audio for example, and some have 448kbps, in the same playlist. What is the output in that case? The way eac3to deals with it is it re-encodes the audio into 640kbps using libAften encoder that it comes with.
Both problems stem from non-consistent list of streams. I think one decent way of dealing with the first problem (out-of-sync issue due to intro) would be for dgdemux to scan m2ts files before demuxing starts, if it discovers that list of streams in all m2ts files of the playlist aren't consistent, then it asks you something like this:
Code: Select all
dgdemux -i MOVIE\BDMV\PLAYLIST\00000.mpls -o output\
Code: Select all
dgdemux
The streams in 00000.mpls [00001.m2ts + 00003.m2ts + 00006.m2ts] aren't consistent:
00001.m2ts 00003.m2ts
1011: Video [AVC] 1011: Video [AVC] ✔
1100: DTS HDMA L+R 48 1536 ✘
1101: PGS subtitles [eng] ✘
Do you want demux 00000.mpls entirely or skip first m2ts? [d] - demux, [sf] - skip first, [sl] - skip last: ...
Especially when sometimes, 00001.m2ts may not cause issues if audio/video tracks in 00003.m2ts have delay added to them, some studios do this, and in cases like that, demuxing the entire mpls even when first m2ts has no audio/subtitle tracks causes no issues as long as dgdemux respects the delay of the playlist on those tracks.
The second issue, where the audio bit rate/type changes between m2ts files is more difficult to solve I think. I haven't tested how dgdemux handles those, I assume it won't re-encode like eac3to does, and it can't "combine" 2 different bit rate audios so I assume it will demux first one, and skip the second one.
for example, if mpls is 00001.m2ts+00002.m2ts+00003.m2ts, and if 00001.m2ts & 00002.m2ts both have AC3@640kbps audio, but 00003.m2ts has AC3@448kbps audio, I assume dgdemux will demux audio just from first two m2ts files and skip the last one, or it will have an error. But again, I haven't tested it so I don't know. There should be a warning in any case, like the above warning when there are inconsistent streams in m2ts files, so that user is aware that demuxed audio is not viable, then he can decide how to handle it. (hopefully in future, there will be a detailed log where all this will be logged.)