DGDemux development

DAE avatar
BDgeek2
Posts: 18
Joined: Tue Jul 07, 2020 10:48 pm

Re: DGDemux development

Post by BDgeek2 »

Please bear with me, this is my first post and it may sound like a very newbie question.

I've been using DGDemux for a couple of months now and I'm loving it. Thanks Rocky, fantastic software!

Now, on the updates/fixes log for slipstream 30, it's stated:
"Fixed file gaps processing for THD audio"

What does it mean in pratical terms?
For exampled, I've demuxed Toy Story 4 UHD that has a DTHD Atmos track with slipstream 29 and muxed it back with MKVToolnix to include the UHD video, saind DTHD Atmos track, plus the BD DTS-HD MA track.
Does it mean this THD track on my mux is incorrect somehow? Does it have any sync issues?

Thanks a lot!
User avatar
Rocky
Posts: 3607
Joined: Fri Sep 06, 2019 12:57 pm

Re: DGDemux development

Post by Rocky »

BDgeek2 wrote:
Tue Jul 07, 2020 10:58 pm
I've demuxed Toy Story 4 UHD that has a DTHD Atmos track with slipstream 29 and muxed it back with MKVToolnix to include the UHD video, saind DTHD Atmos track, plus the BD DTS-HD MA track.
Does it mean this THD track on my mux is incorrect somehow? Does it have any sync issues?
No, it is fine. That fix was for uncommon streams that did not start all major frames with payload_unit_start_indicator=1. TOY_STORY does not do that and it was one of the disks that I had tested with.
User avatar
Rocky
Posts: 3607
Joined: Fri Sep 06, 2019 12:57 pm

Re: DGDemux development

Post by Rocky »

asowaboc wrote:
Tue Jul 07, 2020 6:26 pm
...there's no progress bar? Also, DGDemux seems to be creating .sup files that are invalid and can't be read by MKVToolNix/BDSup2Sub.
There is a marque progress bar and the current m2ts is shown.

Regarding your subs issue, please tell the disk and PID and specify your exact process to show the issue. Also state the error that you encounter.
User avatar
Rocky
Posts: 3607
Joined: Fri Sep 06, 2019 12:57 pm

Re: DGDemux development

Post by Rocky »

asowaboc wrote:
Tue Jul 07, 2020 6:26 pm
DGDemux seems to be creating .sup files that are invalid and can't be read by MKVToolNix/BDSup2Sub.
I just did some spot checks and cannot find any problems. The files are accepted by SubtitleEdit and MKVToolNix without any issues. Please specify the disk, stream, and your process that creates your issue. You don't want Bullwinkle thinking you are FUD'ing us. ;)
User avatar
Bullwinkle
Posts: 338
Joined: Thu Sep 05, 2019 6:37 pm

Re: DGDemux development

Post by Bullwinkle »

Rocky wrote:
Thu Jul 09, 2020 9:56 am
You don't want Bullwinkle thinking you are FUD'ing us.
Too late now. Sayonara asowaboc!
DAE avatar
Guest 2
Posts: 903
Joined: Mon Sep 20, 2010 2:18 pm

Drag & drop

Post by Guest 2 »

Would you please add drag & drop support?
User avatar
Rocky
Posts: 3607
Joined: Fri Sep 06, 2019 12:57 pm

Re: DGDemux development

Post by Rocky »

Drag and drop what onto what?
DAE avatar
CYPHER
Posts: 9
Joined: Tue Sep 03, 2019 12:25 am

Re: DGDemux development

Post by CYPHER »

Hi Rocky, and other devs.

I really appreciate your hard work on DG-Tools :)

I wish to make a small feature request (not sure if I did it in the right place though...): would it be possible to cut the files via the chapterlist (or by an external chapterlist). For the case of audio discs it would be a neat feature. I know it can only be done GOP/audio frame-wise, but still it would be great to have approximate cuts according to a timelist.

Thanks in advance,
Keep up the good work,
Cheers,
DAE avatar
BDgeek2
Posts: 18
Joined: Tue Jul 07, 2020 10:48 pm

Re: DGDemux development

Post by BDgeek2 »

Rocky wrote:
Wed Jul 08, 2020 5:55 am
No, it is fine. That fix was for uncommon streams that did not start all major frames with payload_unit_start_indicator=1. TOY_STORY does not do that and it was one of the disks that I had tested with.
Thanks a lot for the prompt reply Rocky!

BTW, I just read of a tool that claims to correctly demux THD tracks and it specifically mentions DGDemux under it's FAQ.

I don't understand about the technicals and if it's accurate at all, but it occured me to bring it to your attention Rocky.
https://github.com/domyd/mlp

Here's the note:
"[1]: MakeMKV 1.15.1 does eventually maintain A/V sync, but it does so by deleting larger groups of frames on fewer occasions. This isn't perfect, but it's good enough. DGDemux deletes a minor frame at every segment boundary, which is better still, but not perfect"

Later down the same page, there's a Special Thanks note acknowledging your contribution Rocky.
"Special Thanks
Rocky over at the DGDemux forum for figuring out where and how to cut TrueHD bitstreams without causing audio issues or decoder errors."

Could you please shed some light on this issue Rocky?
I mean, with the sole intention of understanding it and not meaning any disrespect, does DGDemux not take the best approach to THD demux?

Thanks again, I really appreciate all the work under DGDemux!
User avatar
Rocky
Posts: 3607
Joined: Fri Sep 06, 2019 12:57 pm

Re: DGDemux development

Post by Rocky »

CYPHER wrote:
Mon Jul 13, 2020 5:50 am
I wish to make a small feature request (not sure if I did it in the right place though...): would it be possible to cut the files via the chapterlist (or by an external chapterlist). For the case of audio discs it would be a neat feature. I know it can only be done GOP/audio frame-wise, but still it would be great to have approximate cuts according to a timelist
Hi CYPHER. What do you mean by an "audio disk". Is there a use case beyond that as well?
User avatar
Rocky
Posts: 3607
Joined: Fri Sep 06, 2019 12:57 pm

Re: DGDemux development

Post by Rocky »

BDgeek2 wrote:
Mon Jul 13, 2020 2:42 pm
does DGDemux not take the best approach to THD demux?
Well, "best" depends on your criteria. domy is a respected Moose-Approved member here and we have had extensive discussions about all this, which you will see if you search a bit. Our solutions are different but the end results are within a few milliseconds of each other. domy seeks what he calls perfection, while I seek a balance between good sync and good performance with low complexity. Can my way be improved? It's possible. But do I want to make a complex mess that is bug prone to gain a few milliseconds in precision? domy has one thing to do while my demuxer is doing so much more. So I wouldn't get anxious over a few milliseconds when the average person can't even detect a 50-100 millisecond desync.
DAE avatar
BDgeek2
Posts: 18
Joined: Tue Jul 07, 2020 10:48 pm

Re: DGDemux development

Post by BDgeek2 »

Thanks a lot Rocky, I really appreciated your answer!

I'll look for the debates you mentioned.
User avatar
Rocky
Posts: 3607
Joined: Fri Sep 06, 2019 12:57 pm

Re: DGDemux development

Post by Rocky »

Discussions, not debates!
DAE avatar
CYPHER
Posts: 9
Joined: Tue Sep 03, 2019 12:25 am

Re: DGDemux development

Post by CYPHER »

Rocky wrote:
Tue Jul 14, 2020 7:13 pm
CYPHER wrote:
Mon Jul 13, 2020 5:50 am
I wish to make a small feature request (not sure if I did it in the right place though...): would it be possible to cut the files via the chapterlist (or by an external chapterlist). For the case of audio discs it would be a neat feature. I know it can only be done GOP/audio frame-wise, but still it would be great to have approximate cuts according to a timelist
Hi CYPHER. What do you mean by an "audio disk". Is there a use case beyond that as well?
By audio disc I mean live concert recordings, like this one: https://www.amazon.com/Hans-Zimmer-Live ... B0757G5PXW
Here each chapter is a different song/audio track, but they share the same playlist on the BD and it would be nice to extract the songs into different files. Furthermore, the bonus disc of e.g. Inception contains the OST of the film in the same manner.

Apart from these, for films/movies this feature is might not be so useful...
User avatar
Rocky
Posts: 3607
Joined: Fri Sep 06, 2019 12:57 pm

Re: DGDemux development

Post by Rocky »

What is "OST"?
DAE avatar
renols
Posts: 150
Joined: Tue Feb 22, 2011 2:34 am

Re: DGDemux development

Post by renols »

Rocky wrote:
Wed Jul 15, 2020 3:18 pm
What is "OST"?
Hi.

Normally it is "Original Sound Track"

renols
User avatar
Rocky
Posts: 3607
Joined: Fri Sep 06, 2019 12:57 pm

Re: DGDemux development

Post by Rocky »

:salute:
User avatar
Rocky
Posts: 3607
Joined: Fri Sep 06, 2019 12:57 pm

Re: DGDemux development

Post by Rocky »

Rocky wrote:
Fri Jul 10, 2020 12:38 pm
Drag and drop what onto what?
@Guest 2

Any chance of an answer or should I just forget this request?
DAE avatar
Guest 2
Posts: 903
Joined: Mon Sep 20, 2010 2:18 pm

Re: DGDemux development

Post by Guest 2 »

Rocky wrote:
Fri Jul 10, 2020 12:38 pm
Drag and drop what onto what?
Sorry, I did not receive notification of reply.

Drag a BD folder onto DGDemux to open it, instead of having to open the folder manually.
User avatar
Rocky
Posts: 3607
Joined: Fri Sep 06, 2019 12:57 pm

Re: DGDemux development

Post by Rocky »

Sure, I can do that but it is low priority, meaning all functionality problems must be fixed first, e.g., episode demuxing chapters and subs timing.
User avatar
Rocky
Posts: 3607
Joined: Fri Sep 06, 2019 12:57 pm

Re: DGDemux development

Post by Rocky »

Guys, can we please start making separate threads for bugs/issues? I'd like to keep this thread for general matters such as feature requests and theoretical discussion.
DAE avatar
Guest 2
Posts: 903
Joined: Mon Sep 20, 2010 2:18 pm

Re: DGDemux development

Post by Guest 2 »

Remotely trying the new version.

Tried to demux a BD (In full bloom) whose main title is composed by 3 m2ts, just audio tracks and subs, no video.

Is it normal that there is no more progress, i.e. the green bar is sliding instead of showing the progress and no percentage?

Not enough bandwidth now to check the sups. Will have a look tomorrow when at home.
User avatar
Rocky
Posts: 3607
Joined: Fri Sep 06, 2019 12:57 pm

Re: DGDemux development

Post by Rocky »

Whether it is "normal" is up to you. It is by design. Full progress could come back one day.
DAE avatar
Guest 2
Posts: 903
Joined: Mon Sep 20, 2010 2:18 pm

Re: DGDemux development

Post by Guest 2 »

Saw drag and drop support.

Great! :salute:
User avatar
Rocky
Posts: 3607
Joined: Fri Sep 06, 2019 12:57 pm

Re: DGDemux development

Post by Rocky »

My pleasure. Thank you for the feature request.
Post Reply