DGDemux development

gonca
Moose Approved/Curly Approved
Posts: 909
Joined: Sun Apr 08, 2012 6:12 pm

Re: DGDemux development

Post by gonca » Mon Oct 12, 2020 9:26 am

Gonna copy some movies from my archive and will try to test today

User avatar
Sherman
Moose Approved
Posts: 124
Joined: Mon Jan 06, 2020 11:19 pm

Re: DGDemux development

Post by Sherman » Mon Oct 12, 2020 9:38 am

Sweet. Thank you, gonca. Would be great if you can test a 3D disk, demuxing all streams and just the MVC stream.

gonca
Moose Approved/Curly Approved
Posts: 909
Joined: Sun Apr 08, 2012 6:12 pm

Re: DGDemux development

Post by gonca » Mon Oct 12, 2020 10:09 am

Copying one of those as well

gonca
Moose Approved/Curly Approved
Posts: 909
Joined: Sun Apr 08, 2012 6:12 pm

Re: DGDemux development

Post by gonca » Mon Oct 12, 2020 11:44 am

Gonna report one disc at a time so my head doesn't explode from the data

VENOM 4K
Primary video in slow is one byte bigger than fast
All other tracks, including DV and PGS, are identical

BUMBLEBEE 4K
Had to use no preallocation
Too many streams and preallocation was using up all free space and then some

One byte issue (I realize it might no be an issue but still reporting)
DV matches
Embedded AC3 matches
all other files match

VENOM 1080p
Size mismatch on AVC file
ac3 files match
PGS files match
can't open dts files

BUMBLEBEE 1080p
AVC made file compare go nuts
all other files match

AGE OF EXTINCTION 3D
AVC file made it go nuts again
*.tag files could not be opened
everything else matches

MVC only
match
Last edited by gonca on Mon Oct 12, 2020 4:07 pm, edited 4 times in total.

User avatar
Rocky
Moose Approved
Posts: 1057
Joined: Fri Sep 06, 2019 12:57 pm

Re: DGDemux development

Post by Rocky » Mon Oct 12, 2020 11:57 am

That's fine. Maybe edit the post instead of making a new post for every disk?

User avatar
Rocky
Moose Approved
Posts: 1057
Joined: Fri Sep 06, 2019 12:57 pm

Re: DGDemux development

Post by Rocky » Mon Oct 12, 2020 9:28 pm

:salute: for your edit

Can you provide purchase links for the last 3 disks? Thank you.

Also please report only issues. You don't have to mention what works. ;)

Finally, 'go nuts' is vague.

gonca
Moose Approved/Curly Approved
Posts: 909
Joined: Sun Apr 08, 2012 6:12 pm

Re: DGDemux development

Post by gonca » Tue Oct 13, 2020 5:04 am

Can you provide purchase links for the last 3 disks?
You mean the 1080p ones?
Venom and Bumblebee were part the 4K set but the blu-ray should be the same

https://www.amazon.ca/Venom-Blu-ray-Bil ... dvd&sr=1-3
https://www.amazon.ca/Bumblebee-Blu-ray ... dvd&sr=1-3
https://www.amazon.ca/Transformers-Age- ... dvd&sr=1-2
Size mismatch is the one byte issue
'go nuts'
Large output from fc due to the filler NALUs

User avatar
Rocky
Moose Approved
Posts: 1057
Joined: Fri Sep 06, 2019 12:57 pm

Re: DGDemux development

Post by Rocky » Tue Oct 13, 2020 11:52 am

All right, Sherman has fixed the DTS.

Ah, I see, the tags files are not generated at all!

OK, I think we're good to go. No further clarification needed.

User avatar
Rocky
Moose Approved
Posts: 1057
Joined: Fri Sep 06, 2019 12:57 pm

Re: DGDemux development

Post by Rocky » Tue Oct 13, 2020 12:19 pm

OK, please re-download the test build. The DTS and tags issues should be fixed. Please advise any further issues you find.

Greatly appreciate your testing, gonca!

gonca
Moose Approved/Curly Approved
Posts: 909
Joined: Sun Apr 08, 2012 6:12 pm

Re: DGDemux development

Post by gonca » Tue Oct 13, 2020 6:07 pm

The DTS and tags issue is fixed but something else popped up
issue.png
issue.png (72.05 KiB) Viewed 1031 times
Please note the different delays on the same files
I'll retest if you wish
It was the Venom 1080p disc
By the way
If you like the transformer movies you would probably like Bumblebee
Edit 1
Mediainfo and MKVToolNIX report delay of 0ms which agrees with the slow demux
Edit 2
If you want me to test more discs let me know

User avatar
Rocky
Moose Approved
Posts: 1057
Joined: Fri Sep 06, 2019 12:57 pm

Re: DGDemux development

Post by Rocky » Tue Oct 13, 2020 7:45 pm

I'll probably have to buy it because I can't duplicate that. I'll compare the code closely to see how a discrepancy like that could happen.

However, I was thinking of getting rid of the DELAY anyway as it should always be 0. Have you ever seen a non-zero value when demuxing slow or with EAC3TO? DGDecNV has to do it because you can set your range such that the project doesn't begin at the start of the first M2TS.

Great to hear DTS and tags are working!

gonca
Moose Approved/Curly Approved
Posts: 909
Joined: Sun Apr 08, 2012 6:12 pm

Re: DGDemux development

Post by gonca » Tue Oct 13, 2020 7:48 pm

I don't remember seeing any non zero delays in BDs
If it helps these are DTS HD-MA tracks

User avatar
Rocky
Moose Approved
Posts: 1057
Joined: Fri Sep 06, 2019 12:57 pm

Re: DGDemux development

Post by Rocky » Tue Oct 13, 2020 7:51 pm

OK, thank you. I'll check all my disks and if there are no non-zero delays in slow mode then bye-bye DELAY! Sherman is back in 1935 but I think I can handle it.

gonca
Moose Approved/Curly Approved
Posts: 909
Joined: Sun Apr 08, 2012 6:12 pm

Re: DGDemux development

Post by gonca » Tue Oct 13, 2020 8:17 pm

One more thing
delay.png
delay.png (67.76 KiB) Viewed 1089 times
This time I kept all the audio for comparison
In the slow demux the ac3 are all -8ms delay and the dts is 0 ms
In the fast demux they are listed as -8 ms
Is it possible the fast demux is somehow using the delay for the ac3 files and applying it to the dts files?

gonca
Moose Approved/Curly Approved
Posts: 909
Joined: Sun Apr 08, 2012 6:12 pm

Re: DGDemux development

Post by gonca » Wed Oct 14, 2020 4:12 pm

I realize that you are considering removing delay reporting but I decided to run some quick tests to try and narrow this down.
My regular demux >> Video + Primary eng audio (DTS HD-MA in this case) + eng subtitles
Delays match between slow and fast

Primary eng audio
Delays match

Demux both DTS HD-MA tracks
Delays match

Demux both DTS HD-MA tracks + any ac3 track
Delays don't match
It is as if the ac3 delay is being copied over

It might just be one of those once in a blue moon things

User avatar
Rocky
Moose Approved
Posts: 1057
Joined: Fri Sep 06, 2019 12:57 pm

Re: DGDemux development

Post by Rocky » Wed Oct 14, 2020 4:21 pm

OK, thank you. I'll check it out.

gonca
Moose Approved/Curly Approved
Posts: 909
Joined: Sun Apr 08, 2012 6:12 pm

Re: DGDemux development

Post by gonca » Wed Oct 14, 2020 4:47 pm

Tried 3 more movies with similar dts and ac3 track mixtures
If only dts is demuxed then the delays match
If only ac3 is demuxed then the delays match
If dts and ac3 are both demuxed slow seems to have the correct delays, but in fast demux the dts tracks are assigned the delay values of the ac3 tracks

User avatar
Rocky
Moose Approved
Posts: 1057
Joined: Fri Sep 06, 2019 12:57 pm

Re: DGDemux development

Post by Rocky » Wed Oct 14, 2020 7:34 pm

Yes, thank you. I'll release a fix tomorrow. Your theory is correct. ;)

User avatar
Sherman
Moose Approved
Posts: 124
Joined: Mon Jan 06, 2020 11:19 pm

Re: DGDemux development

Post by Sherman » Wed Oct 14, 2020 9:21 pm

Just popping in to say it's looking possible to get Albert to join the forum. He wants some assurances about not allowing stupid people in here. I said, other than Natasha, should be no problem. And he wants immediate Moose or Britney Approval. ;)

Great job Rocky on the fast mode. Going back down. Wish me luck...

User avatar
Bullwinkle
Moose Approved
Posts: 164
Joined: Thu Sep 05, 2019 6:37 pm

Re: DGDemux development

Post by Bullwinkle » Wed Oct 14, 2020 9:39 pm

Stop it, Sherman! You'll make me project from my second stomach. Honorary stomping award coming your way. Bring Albert back with you and you could be Moose Lodge material. Of course he can have whatever approval he wants.

User avatar
Rocky
Moose Approved
Posts: 1057
Joined: Fri Sep 06, 2019 12:57 pm

Re: DGDemux development

Post by Rocky » Thu Oct 15, 2020 8:32 am

@gonca

Please re-download the test version. The wrong delay values for DTS should be fixed.

User avatar
Sherman
Moose Approved
Posts: 124
Joined: Mon Jan 06, 2020 11:19 pm

Re: DGDemux development

Post by Sherman » Thu Oct 15, 2020 10:29 am

We're back! Albert is going to make a decision and let me know.

Yeah Bullwinkle, that FixTHDGaps() function is ridiculously slow. Too many small reads and writes. Have to do my own read and write buffering. OS buffering is just not enough because system calls are slow all by themselves. Thanks for pointing it out.

EDIT: I have now fully read/write buffered it and it now fixes a 5GB file in 4 seconds, versus almost a minute with the old version. It's speedy now, like DGSplit. 8-) I'll test it and then commit it for integration into the release.

User avatar
Rocky
Moose Approved
Posts: 1057
Joined: Fri Sep 06, 2019 12:57 pm

Re: DGDemux development

Post by Rocky » Thu Oct 15, 2020 10:31 am

Way to go Sherm!
It's speedy now, like DGSplit.
Thanks! My ticket out of the Box of Shame.

User avatar
Sherman
Moose Approved
Posts: 124
Joined: Mon Jan 06, 2020 11:19 pm

Re: DGDemux development

Post by Sherman » Thu Oct 15, 2020 11:27 am

I updated the fast mode test build with the FixTHDGaps() speedup (applies to both slow and fast modes), so please re-download and test. If no adverse feedback is received, maybe Rocky will update build 44.

gonca
Moose Approved/Curly Approved
Posts: 909
Joined: Sun Apr 08, 2012 6:12 pm

Re: DGDemux development

Post by gonca » Thu Oct 15, 2020 4:10 pm

Delays are all good now.
Good job :hat:

I'll try to find some movies with seamless branching to test Gaps Processing

Post Reply