[RESOLVED] Disc Analysis (option -d)

Post Reply
DAE avatar
arrgh
Posts: 49
Joined: Wed Jun 24, 2020 4:51 pm

[RESOLVED] Disc Analysis (option -d)

Post by arrgh »

...the following is maybe more a feature request then a bug report...

here it comes:
this is about an issue with my "favorite" 3D disc "Valerian" we were discussing earlier...
I stumbled across it, because of a discrepancy between eac3to and DGdemux output. Eac3to reports only one mpls (00021.mpls) which has an mvc stream:

Image

DGDemux on the other hand reports two main mpls:

Code: Select all

DGDemux 1.0.0.36 by Donald A. Graft
Copyright (C) 2019-2020 Donald A. Graft, All Rights Reserved

PlayLists:
00021.mpls 02:17:04
00022.mpls 02:17:04
00105.mpls 00:12:00
in contrast to eac3to, DGDemux claims that 00021 does not have a mvc (very likely a problem of eac3to):

Image

but 00022 does, but it is not reflected it the "M2TS list"...:

Image

so, now the feature request. it would be very useful for automated processing of discs, if the disc analysis (option -d) would look like this (or equivalent):

Code: Select all

DGDemux 1.0.0.36 by Donald A. Graft
Copyright (C) 2019-2020 Donald A. Graft, All Rights Reserved

PlayLists:
00021.mpls 02:17:04, AVC, 13 Chapters
00022.mpls 02:17:04, AVC/MVC, 13 Chapters
00105.mpls 00:12:00, AVC
with this it would be directly visible what the difference between 00021 and 00022 is; on top, the info about the chapters is in my experience usefull to distinguish between main-feature and extra-files, like making-of;
especially in the case of series, where the episodes are short, an extra-feature can easily be of the same length like one episode; so, the chapters can be the one significant hint...

Thanks!
User avatar
Rocky
Posts: 3557
Joined: Fri Sep 06, 2019 12:57 pm

Re: Disc Analysis (option -d)

Post by Rocky »

It's a reasonable request to have that additional information returned for -d. It changes my design a bit but I'll see if it is possible. Thank you for the request.
DAE avatar
arrgh
Posts: 49
Joined: Wed Jun 24, 2020 4:51 pm

Re: Disc Analysis (option -d)

Post by arrgh »

super! :salute:
DAE avatar
arrgh
Posts: 49
Joined: Wed Jun 24, 2020 4:51 pm

Re: Disc Analysis (option -d)

Post by arrgh »

@Rocky
thanks for working on the additional info in Disk Analysis.
Ihave checked the first step in version .37... it seems that it is a little bit too optimistic:
it shows that plalist 00105 has chapters, while MakeMKV says "no"...
Image

Image

for playlist 00022 MakeMKV displays the chapters like this:
Image


Thanks!
User avatar
Rocky
Posts: 3557
Joined: Fri Sep 06, 2019 12:57 pm

Re: Disc Analysis (option -d)

Post by Rocky »

Knew that. It's an incremental step. Patience!
User avatar
Rocky
Posts: 3557
Joined: Fri Sep 06, 2019 12:57 pm

Re: Disc Analysis (option -d)

Post by Rocky »

Please give me your MPLS file that has no chapters. Thank you.
DAE avatar
arrgh
Posts: 49
Joined: Wed Jun 24, 2020 4:51 pm

Re: Disc Analysis (option -d)

Post by arrgh »

here the mpls
Attachments
00105.zip
(282 Bytes) Downloaded 506 times
User avatar
Rocky
Posts: 3557
Joined: Fri Sep 06, 2019 12:57 pm

Re: Disc Analysis (option -d)

Post by Rocky »

The MPLS contains 2 active chapter marks. I cannot be held responsible for other applications.
DAE avatar
arrgh
Posts: 49
Joined: Wed Jun 24, 2020 4:51 pm

Re: Disc Analysis (option -d)

Post by arrgh »

@Rocky
understood...
I checked with MediaInfo and with TsmuxeR and you are right. There are two Chapter entries:

Image

Image

but the interesting detail is, that Chapter 2 starts (more or less) at the end of the whole playlist, which means in fact it is just 1 Chapter, or in other words, "no real chapters"...
so, my conclusion would be, either to interpret a playlist with just 2 chapters where the second starts at the end, as a playlist with "no chapters", or to print "2 Chapters", so the user can decide whether he considers this as real chapters or not...


Edit:
as can be seen here, a real chapter starts before the end of the Playlist (2:06:18 vs 2:17:04):

Image

Thanks!
User avatar
Rocky
Posts: 3557
Joined: Fri Sep 06, 2019 12:57 pm

Re: Disc Analysis (option -d)

Post by Rocky »

Thank you. I already have local changes that show the number of chapters on the stream list (after selecting an MPLS). I'd rather have the user make the decision about them. It is not so terrible to generate a chapters file. And I believe in exposing all information to the user.

Now I need to parse and return information on the -d MPLS list.
User avatar
Rocky
Posts: 3557
Joined: Fri Sep 06, 2019 12:57 pm

Re: Disc Analysis (option -d)

Post by Rocky »

Here is what I have implemented for -d output (TOY_STORY_4_3D):

-----
DGDemux 1.0.0.37 by Donald A. Graft
Copyright (C) 2019-2020 Donald A. Graft, All Rights Reserved

PlayLists:
00800.mpls 01:40:03 [35 chapters] [3D]
00801.mpls 01:40:03 [35 chapters] [3D]
00802.mpls 01:40:03 [35 chapters] [3D]
00805.mpls 01:40:03 [35 chapters] [3D]
01649.mpls 00:08:50 [1 chapters] [3D]
01610.mpls 00:08:20 [1 chapters] [3D]
01606.mpls 00:05:45 [1 chapters] [3D]
01604.mpls 00:05:36 [1 chapters] [3D]
01651.mpls 00:05:24 [1 chapters] [3D]
01624.mpls 00:05:21 [1 chapters] [3D]
01635.mpls 00:05:18 [1 chapters] [3D]
01662.mpls 00:05:09 [1 chapters] [3D]
-----

I need to code review and regression test and then I will give you a test version to try on Valerian.
DAE avatar
arrgh
Posts: 49
Joined: Wed Jun 24, 2020 4:51 pm

Re: Disc Analysis (option -d)

Post by arrgh »

very nice ! :) :)
DAE avatar
arrgh
Posts: 49
Joined: Wed Jun 24, 2020 4:51 pm

Re: Disc Analysis (option -d)

Post by arrgh »

... if you insist on having "1 chapters" instead of "" (meaning no chapters at all)... I would ask you to print "01 chapters" instead...
this is easier to parse...

Thanks!
DAE avatar
arrgh
Posts: 49
Joined: Wed Jun 24, 2020 4:51 pm

Re: Disc Analysis (option -d)

Post by arrgh »

version .38 works niecely: the correct marking of 3D and the number of chapters is given:

Code: Select all

DGDemux 1.0.0.38 by Donald A. Graft
Copyright (C) 2019-2020 Donald A. Graft, All Rights Reserved

PlayLists:
00021.mpls 02:17:04 [13 chapters]
00022.mpls 02:17:04 [13 chapters] [3D]
00105.mpls 00:12:00 [2 chapters]
I have also checked with a couple of other discs (against Mediainfo) and have seen that there doesn't seem to exist a strict rule about the chapters. Some playlists have at the very end of the playlist-playtime a "very last" chapter entry, some don't... so, aswell "1 chapter" as "2 chapters" can mean "no real chapters"...
anyways, thank you very much! that helps a lot! :hat:
User avatar
Rocky
Posts: 3557
Joined: Fri Sep 06, 2019 12:57 pm

Re: Disc Analysis (option -d)

Post by Rocky »

You're welcome.
User avatar
Emulgator
Posts: 22
Joined: Tue May 12, 2020 9:39 am

Re: [RESOLVED] Disc Analysis (option -d)

Post by Emulgator »

arrgh, the chapters set close to the stream end may be intended as a kunstgriff to help in jumping to next object
using skip forward button on remote and not having to code extra commands for that stituation.
I remember to have seen that with DVDs as well.
Just to help with understanding how to count them:
As logical instance they do exist, from a viewers' point of view maybe not.
Until he get his foot in that door by issuing remote/button commands quicker than the remaining playtime of that offending video stream.
Post Reply