Cropping issue

Guest 2 · Post by **Guest 2** » Fri Feb 05, 2021 9:12 am

I was about reencoding The Godfather and I noticed a small cropping issue. I don't know if it is cosmetic, functional or both.

Here is a small clip, where you can reproduce it: https://www.mediafire.com/file/2o3s41o1 ... er.7z/file

Just drag it to DGIndexNV, it will have a small black bar at the bottom.

Now open cropping. Try with 4, nothing happens, try 8, nothing happens.

With 16 the small bar at the bottom will become white crossed (and a bit of top and right part too).

Push back 8 or 4 button and the bottom part will remain white.

I suppose it's the 8 pixels from the 1088 height, so why not to render it as white crossed on the opening?

Post by **Rocky** » Fri Feb 05, 2021 11:05 am

Yes, complications from 1088 versus 1080. I'll do something to make the handling sensible for cropping. Thank you for the report.

Guest 2 · Post by **Guest 2** » Fri Feb 05, 2021 2:24 pm

Rocky wrote: ↑
Fri Feb 05, 2021 11:05 am
Thank you for the report.

You are always the most welcome.

Post by **Rocky** » Fri Feb 05, 2021 4:55 pm

The cropping is misbehaving of course with coded 1088, but worse is that the black bar should not appear at all at the bottom (the video fills 1080). I have both fixed locally and will release with the aspect ratio stuff this evening or tomorrow morning.

Can't believe this wasn't noticed until now.

Post by **Rocky** » Fri Feb 05, 2021 5:07 pm

I updated the Vraelon test build with the fix for this issue. Please test and advise.

http://rationalqm.us/misc/DGIndexNV_vraelon.rar

Guest 2 · Post by **Guest 2** » Sat Feb 06, 2021 3:20 am

Rocky wrote: ↑
Fri Feb 05, 2021 4:55 pm
Can't believe this wasn't noticed until now.

I think that it was introduced with the new cropping system, while I was offline. Previously, at least with the builds I tried, I never had that issue. And you know how precise I am.

Rocky wrote: ↑
Fri Feb 05, 2021 5:07 pm
I updated the Vraelon test build with the fix for this issue. Please test and advise.

Tested with 3 different BDs and it's working so far.

Post by **Rocky** » Sat Feb 06, 2021 9:14 am

Thank you. Released as slipstream 226.

Guest 2 · Post by **Guest 2** » Tue Feb 09, 2021 12:08 pm

Unfortunately another cropping issue arose.

Look at http://www.mediafire.com/file/7azr250xr ... da.7z/file

Even cropping, a black bar remains in the bottom part. If I recall well, it worked correctly before the fix.

Post by **Rocky** » Tue Feb 09, 2021 1:13 pm

I don't understand. You mean when serving with DGSource()? You have to either export the cropping to your script (see user manual) or give the cropping manually in your DGSource() invocation.

Or maybe you are saying that autocrop is having an issue with it?

Guest 2 · Post by **Guest 2** » Tue Feb 09, 2021 3:21 pm

Rocky wrote: ↑
Tue Feb 09, 2021 1:13 pm
Or maybe you are saying that autocrop is having an issue with it?

I haven't been clear, what I meant is with autocrop in DGIndexNV.

Post by **Rocky** » Tue Feb 09, 2021 4:13 pm

Looks like autocropping may have suffered a regression. Investigating...

Post by **Rocky** » Wed Feb 10, 2021 10:29 am

Aha, the problem is not with cropping at all. The frame is not being displayed properly in the DGIndexNV window. In other words, it is a preview issue. It's a regression from the new code that supported main window resizing. I have a fix working but have to regression test before giving a test version.

Post by **Rocky** » Wed Feb 10, 2021 11:17 am

OK, guys, test this:

http://rationalqm.us/misc/DGIndexNV_crop_fix.exe

Guest 2 · Post by **Guest 2** » Wed Feb 10, 2021 11:48 am

Rocky wrote: ↑
Wed Feb 10, 2021 11:17 am
OK, guys, test this

It fixes the black bar but I have another issue/doubt for you.

Download the last file I sent (http://www.mediafire.com/file/7azr250xr ... da.7z/file) and try to Auto Crop.

Auto Crop mod 4 -> 1920 [mod 32] x 1040 [mod 16]
Auto Crop mod 8 -> 1920 [mod 32] x 1040 [mod 16]
Auto Crop mod 16 -> 1920 [mod 32] x 1032 [mod 8]

Post by **Rocky** » Wed Feb 10, 2021 11:58 am

Investigating...

Meanwhile, re-download the crop_fix build and test demux of MKV chapters with -a in your workflow. You must have mkvextract.exe in the same directory as DGIndexNV.exe.

Post by **Rocky** » Wed Feb 10, 2021 12:32 pm

OK, please re-download again. Autocrop 16 should show properly.

I want to carefully re-visit the autocrop code, but this should be OK for now. When we can't hit the mod exactly, I'm wondering if we should crop too much or too little. Currently we do too little, but that can leave a small black bar. If we do too much we will crop a small amount of good video. Hmm, make it selectable?

Guest 2 · Post by **Guest 2** » Wed Feb 10, 2021 2:50 pm

Rocky wrote: ↑
Wed Feb 10, 2021 12:32 pm
OK, please re-download again. Autocrop 16 should show properly.

Seems good to me.

Rocky wrote: ↑
Wed Feb 10, 2021 12:32 pm
Hmm, make it selectable?

AFAIK, in h.265 horizontal intra prediction uses pixels from the border of the horizontally previous block as reference
for the pixels of the current block. Thus having no black lines would be better. Anyway having a selection in option would be fine. The only important thing is never go lower than mod 4, due to chroma subsampling.

Personally, I use Mod with a pinch of salt and I hate to have black lines, unless they are in the number of 2 pixel max per border. If 3, I cut.

P.S: When you have time, please, put a option to decide if to extract chapters as xml or txt. Does DGIndexNV read ini file when using CLI? If so, even a ini option would be enough.

Post by **Rocky** » Wed Feb 10, 2021 7:29 pm

I'll work on those two things for the next build. I want to get the fixes out first. Thank you for your suggestions. Yes, CLI reads the INI file.