[RESOLVED] MKV demux support

Support forum for DGDecNV
Post Reply
User avatar
hydra3333
Posts: 394
Joined: Wed Oct 06, 2010 3:34 am
Contact:

Re: Feature Requests

Post by hydra3333 »

thank you :bravo:
I really do like it here.
User avatar
admin
Posts: 4551
Joined: Thu Sep 09, 2010 3:08 pm

Re: Feature Requests

Post by admin »

You are most welcome. :)
DAE avatar
Guest

Re: Feature Requests

Post by Guest »

With MKV
Dolby Atmos is extracted but the file type (thd) is not written with the file name
Example
Clip B
Extracted audio name is written as B, should be B.thd
Adding .thd to the file name makes it a valid sound track
The HD variants of DTS, including DTS X, are named properly
User avatar
admin
Posts: 4551
Joined: Thu Sep 09, 2010 3:08 pm

Re: Feature Requests

Post by admin »

Please provide a test clip for analysis. Thank you.

I need to know which text identifier is used, e.g., like "A_VORBIS". I can see that my code does not add the extension when the identifier is not on my list, and I don't have anything for Dolby Atmos right now. I'll check the MKV spec to see if it is listed there.
DAE avatar
Guest

Re: Feature Requests

Post by Guest »

Uploading test clip now
Will let you know when it is ready
User avatar
admin
Posts: 4551
Joined: Thu Sep 09, 2010 3:08 pm

Re: Feature Requests

Post by admin »

Super, thanks. It's not listed in the MKV codec spec.
User avatar
admin
Posts: 4551
Joined: Thu Sep 09, 2010 3:08 pm

Re: Feature Requests

Post by admin »

Guessing from some googling that it will be "A_TRUEHD" but I will confirm with your test file.
User avatar
admin
Posts: 4551
Joined: Thu Sep 09, 2010 3:08 pm

Re: Feature Requests

Post by admin »

Thank you for the test file, gonca. Yup, it's "A_TRUEHD" and I have it added locally. Will slipstream tomorrow. Thanks for pointing it out. :hat:
DAE avatar
Guest 2
Posts: 903
Joined: Mon Sep 20, 2010 2:18 pm

Re: Feature Requests

Post by Guest 2 »

Great update.

How are efforts going with chapters and subs?
User avatar
admin
Posts: 4551
Joined: Thu Sep 09, 2010 3:08 pm

Re: Feature Requests

Post by admin »

Technically it's pretty easy but I'm still thinking over the right GUI interface for it. One consideration is that subtitles are not just in MKV and if I implement it for MKV, I should do it for all the other containers. In that case another top-level menu item "Subtitles" would be appropriate and would lead to a dialog similar to the existing Audio menu. But that would all be a massive job. At the other end of the spectrum I could support only MKV for now and do it by adding a simple checkbox somewhere that says "demux subtitles also". I suppose chapters would raise similar questions but I have been focused on subtitles so far.

Your thoughts on this would be appreciated.

Glad you like the update.
DAE avatar
Guest

Re: Feature Requests

Post by Guest »

Another thing to consider would be to add an option similar to "Output Trimmed TS", an evolution to the MKV/MP4 expanded support
Maybe Output Trimmed MKV (or fill in the extension?) kind of idea
I realize that it is probably an enormous amount of work and might not see the light of day, just throwing out some possibilities
User avatar
admin
Posts: 4551
Joined: Thu Sep 09, 2010 3:08 pm

Re: Feature Requests

Post by admin »

Sure it would be nice but as you say a major effort. I added the trimmed TS support because I personally needed it for my Colossus captures and it was fairly easy to do, not because anyone asked for it. So until I need it for myself, I won't invest any time in it. (BTW, cutting TS is much easier than cutting MKV/MP4.)

I have two fixes for the new MP4 audio demuxing that I will slipstream with the A_TRUEHD fix later today.
DAE avatar
Guest

Re: Feature Requests

Post by Guest »

Just brought it up because as you consider how to implement the new options in the GUI, maybe leave the door open so that in future if you do decide to do it, you can expand on the GUI options instead of redesigning it
Any upgrades you do to DGDecodeNV / DGIndexNV are appreciated :bravo:
DAE avatar
Guest 2
Posts: 903
Joined: Mon Sep 20, 2010 2:18 pm

Re: Feature Requests

Post by Guest 2 »

admin wrote:
Sun Feb 18, 2018 8:34 am
Glad you like the update.
Technically, aside from DGI generation, everything in a container is a stream and thus a "streams" menu would be a nice replacement for audio one.

You could simply present all the included streams, from video to audio, subs and chapters (and attachments too, if any) and let user select the one to be demuxed, such as we do with audio.

Plain and simple solution, IMHO.

EDIT: get a look at gMKVExtractGUI interface. Simple and very easy to use.
User avatar
admin
Posts: 4551
Joined: Thu Sep 09, 2010 3:08 pm

Re: Feature Requests

Post by admin »

Great thoughts, thanks.
User avatar
admin
Posts: 4551
Joined: Thu Sep 09, 2010 3:08 pm

Re: Feature Requests

Post by admin »

@Guest 2

I have things going based on your idea. So far I am supporting only SRT subtitles (S_TEXT/UTF8). What other subtitle formats would you expect to be supported and do you have sample files for them? Thanks.
DAE avatar
jpsdr
Posts: 214
Joined: Tue Sep 21, 2010 4:16 am

Re: Feature Requests

Post by jpsdr »

I think, in this order, the most common used (after SRT) are :
SSA/ASS
PGS (also called SUP)
SUB/IDX
DAE avatar
Guest 2
Posts: 903
Joined: Mon Sep 20, 2010 2:18 pm

Re: Feature Requests

Post by Guest 2 »

jpsdr wrote:
Tue Feb 20, 2018 3:14 am
I think, in this order, the most common used (after SRT) are :
SSA/ASS
PGS (also called SUP)
SUB/IDX
That's it.

Consider that ass format sometimes includes fonts as attachments, such as when superimposing non latin signals with translations.

If needed I can provide you an example.
User avatar
admin
Posts: 4551
Joined: Thu Sep 09, 2010 3:08 pm

Re: Feature Requests

Post by admin »

Thank you, gents. I'll start with SSA/ASS. I am able to make my own sample files with different subtitle types so there's no need for you to provide samples.
User avatar
admin
Posts: 4551
Joined: Thu Sep 09, 2010 3:08 pm

Re: Feature Requests

Post by admin »

Alright gents, start your engines. Here is a test version supporting SRT and SSA in MKV.

http://rationalqm.us/misc/Guest 2.zip

The general framework is there now to add new formats and support for TS/PS/MP4 as needed. Note that I decided not to include the video in the newly renamed Demux menu (was the Audio menu), for various reasons. I may revisit that later when my coding batteries recharge.

Your testing will be appreciated. It should be obvious how everything works. I'll revise the manual when the changes stabilize.
DAE avatar
Guest 2
Posts: 903
Joined: Mon Sep 20, 2010 2:18 pm

Re: Feature Requests

Post by Guest 2 »

admin wrote:
Tue Feb 20, 2018 6:37 am
Thank you, gents. I'll start with SSA/ASS. I am able to make my own sample files with different subtitle types so there's no need for you to provide samples.
With attached fonts too? :bow:
User avatar
admin
Posts: 4551
Joined: Thu Sep 09, 2010 3:08 pm

Re: Feature Requests

Post by admin »

No. You can feel free to give me any samples you like.
DAE avatar
Guest 2
Posts: 903
Joined: Mon Sep 20, 2010 2:18 pm

Re: Feature Requests

Post by Guest 2 »

admin wrote:
Tue Feb 20, 2018 10:53 am
Alright gents, start your engines. Here is a test version supporting SRT and SSA in MKV.
  • SRT extraction finishes after Finished! is shown in toolbox.
  • sometimes SRT are not extracted at all, truncated or bit for bit different from MKVTools extracted ones
Please, more than name to the stream and channel number, add language, description and delay if present.
DAE avatar
Guest 2
Posts: 903
Joined: Mon Sep 20, 2010 2:18 pm

Re: Feature Requests

Post by Guest 2 »

admin wrote:
Tue Feb 20, 2018 1:05 pm
No. You can feel free to give me any samples you like.
Tom I will.
User avatar
admin
Posts: 4551
Joined: Thu Sep 09, 2010 3:08 pm

Re: Feature Requests

Post by admin »

Who is Tom? :lol:

I'm aware of the "Finished" coming too early and will fix that. The only reason I can think of for missing or truncated SRTs is that you exit DGIndexNV right after seeing "Finished" and before the demuxing thread is complete. Good to see you are on your toes with the testing. ;)
Post Reply