Page 6 of 8

Re: Feature Requests

Posted: Tue Mar 06, 2018 6:21 am
by admin
Guest 2 wrote:
Tue Mar 06, 2018 6:15 am
admin wrote:
Sat Mar 03, 2018 5:43 pm
There should be no delay on MKV demuxed stuff, so I don't do anything with that.
By design? Usually demuxing leaves audio tracks as they are. AFAIK the only way to correct it is to put it back when muxing again, reencoding or trimming in some way.
I suppose you posted that before reading all the posts. I include the delay in the demuxed filename.

Re: Feature Requests

Posted: Tue Mar 06, 2018 6:23 am
by admin
Guest 2 wrote:
Tue Mar 06, 2018 6:16 am
admin wrote:
Sun Mar 04, 2018 6:00 pm
No chapter support. I was trying to decide if it is worth it.
IMHO yes, as we are looking for a GMkv (or similar) alternative.
Can you please describe a task and its workflow that uses demuxed chapter information? I need to understand the context.

And how would you expect chapter demuxing to interact with the configured project range, if at all. If there is no interaction then the simplest thing to do may be to automatically launch mkvextract for the chapters.

Are you looking for simple or XML format for the demuxed chapter files?

Re: MKV demux support

Posted: Tue Mar 06, 2018 9:35 am
by admin
I have uploaded a new version with MKV chapters demux support. It requires a copy of mkvextract.exe to be in the same directory as DGIndexNV.exe and currently does only XML.

http://rationalqm.us/misc/DGIndexNV_test.exe

@Guest 2

Since you're the guy that asked for this, I'll appreciate your feedback on whether it is doing what you need.

Re: Feature Requests

Posted: Tue Mar 06, 2018 9:47 am
by Guest 2
admin wrote:
Tue Mar 06, 2018 6:21 am
I suppose you posted that before reading all the posts. I include the delay in the demuxed filename.
Ok. I understood you corrected delay while demuxing. :oops:

Re: MKV demux support

Posted: Tue Mar 06, 2018 9:48 am
by admin
I was imprecise in my language. :?

What do you think of the chapters support?

Re: Feature Requests

Posted: Tue Mar 06, 2018 9:50 am
by Guest 2
admin wrote:
Tue Mar 06, 2018 6:23 am
Can you please describe a task and its workflow that uses demuxed chapter information? I need to understand the context.
Demux a BD, compress with x264, compress audio to ac3 or aac, remux with chapters, watch on a laptop while traveling by train or plane :D
admin wrote:
Tue Mar 06, 2018 6:23 am
Are you looking for simple or XML format for the demuxed chapter files?
Whatever format you are more confortable to extract. MKVToolnix can digest any.

Re: MKV demux support

Posted: Tue Mar 06, 2018 9:51 am
by Guest 2
admin wrote:
Tue Mar 06, 2018 9:35 am
Since you're the guy that asked for this, I'll appreciate your feedback on whether it is doing what you need.
Gonca too. We are partners in crime :D

Will test asap.

Re: MKV demux support

Posted: Tue Mar 06, 2018 9:53 am
by admin
Thanks, Guest 2. I suppose I should call you two guys the usual suspects now, huh?

The main thing is that it does not honor the project range for chapters. But it's not clear that such a thing would be needed, and in any case, I could post-fix-up the demuxed file based on the StartTime of the project range (I hope it's not needed!) The scenario you gave would not require it.

Here's another thought. I would like to emulate gMKVExtractGUI's checkbox design but Win32 does not have a listbox with checkable items. I'll see if I can subclass it and make one that does. That is the reason for the somewhat clunky selection method I have now.

SRT delay

Posted: Tue Mar 06, 2018 3:24 pm
by Guest 2
@admin :hat:

I was playing a bit with Justice League and Detroit BDs.

I noticed that the srt filenaming gives strange delay results, such as: DELAY_150751ms or DELAY_166668ms.

I have compared with the srt extracted by GMKV and they are identical in time codes and contents.

Re: MKV demux support

Posted: Tue Mar 06, 2018 3:40 pm
by Guest
The delay is the start time code of the first subtitle

Re: MKV demux support

Posted: Tue Mar 06, 2018 3:42 pm
by Guest
I suppose I should call you two guys the usual suspects now, huh?
Usual?
Not odd, rare, strange, etc?
Just usual/average :facepalm: ;)

Re: MKV demux support

Posted: Tue Mar 06, 2018 3:44 pm
by admin
gonca wrote:
Tue Mar 06, 2018 3:40 pm
The delay is the start time code of the first subtitle
Ah, so that is the significance of it. Do we really need the delay value in the filename then? Seems not to me.

Re: MKV demux support

Posted: Tue Mar 06, 2018 3:45 pm
by Guest
Realistically, no
Because it is a subtitle the delay in the name it is ignored by mkvmerge

Re: MKV demux support

Posted: Tue Mar 06, 2018 3:46 pm
by Guest 2
gonca wrote:
Tue Mar 06, 2018 3:40 pm
The delay is the start time code of the first subtitle
I can't understand why.

Delay should be the one you put in MKVToolnix when you don't want to edit srt with same fps but from different source (and it happens, when you need to translate from foreign language and the foreign BD edition has more intro or less than yours).

Re: MKV demux support

Posted: Tue Mar 06, 2018 3:47 pm
by Guest 2
gonca wrote:
Tue Mar 06, 2018 3:45 pm
Because it is a subtitle the delay in the name it is ignored by mkvmerge
AFAIK it's not true. MKVToolnix honors delay for every stream.

Re: MKV demux support

Posted: Tue Mar 06, 2018 3:49 pm
by Guest
In the PGS subtitle I tested that is how it works out
You can always manually enter a delay into mkvmerge
I merged the subtitles with the delays in the name, extracted them and they showed no difference
Note that I only use PGS subtitles

Re: MKV demux support

Posted: Tue Mar 06, 2018 4:15 pm
by admin
I'm going to remove it from subtitle filenames. It doesn't have the same significance as for audio because audio is expected to start right away with the video while the first sub may not come for a while, so the offset between the start of the video and the first subtitle block has no significance.

Re: MKV demux support

Posted: Tue Mar 06, 2018 4:35 pm
by admin
New version:

http://rationalqm.us/misc/DGIndexNV_test.exe

Removes DELAY from subtitles and fixes Guest 2's crash. Marked as slipstream 130 in preparation for release.

Re: MKV demux support

Posted: Wed Mar 07, 2018 10:11 am
by Guest 2
gonca wrote:
Tue Mar 06, 2018 3:49 pm
You can always manually enter a delay into mkvmerge
MKVToolnix honors the delay you put to subs when muxing, I tried and asked on MKV thread too. I am asking how is possible to reverse engineer the delay when demuxing.

Re: MKV demux support

Posted: Wed Mar 07, 2018 10:37 am
by admin
I don't think it is possible, because there is no Delay field in MKV. It is just used during muxing to adjust all the timestamps. Once that adjustment is made, that delay value is gone and assuming the right value was used, you would not need to re-apply it if re-muxing. You would have to play the movie with subtitles enabled to see if the sync is good. If not, a new delay value can be specified during the re-mux.

I'm getting ready to slipstream this later today. Please advise if you find anything I should know about.

Thanks, everybody, for your assistance with the design and testing of this new feature. :hat:

Re: MKV demux support

Posted: Wed Mar 07, 2018 10:56 am
by admin
gonca wrote:
Tue Mar 06, 2018 3:42 pm
I suppose I should call you two guys the usual suspects now, huh?
Usual?
Not odd, rare, strange, etc?
Just usual/average :facepalm: ;)
Just a reference to a well-known film. I imagine that you and Guest 2 could have easily been cast for roles there.

http://www.imdb.com/title/tt0114814/

Re: MKV demux support

Posted: Wed Mar 07, 2018 11:09 am
by Guest
Yep
I am the good looking one

Re: MKV demux support

Posted: Wed Mar 07, 2018 11:31 am
by Guest
Guest 2 wrote:
Wed Mar 07, 2018 10:11 am
gonca wrote:
Tue Mar 06, 2018 3:49 pm
You can always manually enter a delay into mkvmerge
MKVToolnix honors the delay you put to subs when muxing, I tried and asked on MKV thread too. I am asking how is possible to reverse engineer the delay when demuxing.
I just repeated the experiment
Demuxed the PGS subtitle from a MKV file
Edited the name to give it a delay
Remuxed this PGS into the MKV
Extracted the PGS from the MKV
All 3 PGS streams (original, renamed, muxed/demuxed) have the exact same time codes and the extracted PGS stream, by gMKVExtract, has no delay in the name
MKVToolNix honours the delay when you manually enter it into the delay field
Please try it for yourself with a PGS subtitle

Re: MKV demux support

Posted: Wed Mar 07, 2018 11:43 am
by Guest
@Guest 2
MKVToolnix honors the delay you put to subs when muxing
When you asked on the other forum, did you notice everyone mentioned mkvmerge, which is a CLI app
You were also asked for a sample command line, the subtitle delay must be explicitly stated in the cmd line
Same as manually entering it into the delay field
I might be wrong or there could be a bug in MKVToolNix GUI
My money would be that delays in subtitles must be explicitly stated

Re: MKV demux support

Posted: Wed Mar 07, 2018 11:53 am
by admin
NEWS.md 2006:

* mmg: new feature: Pre-set the "delay" input field for audio tracks if the file name
contains something like "DELAY XX" where XX is a number.

But only for audio, not subtitles. I tested this; only audio is auto-detected from the file name.

The reason it wasn't being picked up for my filenames was because I had an underscore rather than a space after the word DELAY. I will correct that for the slipstream. Thanks, guys, for bringing that to light.

DELAY pickup from the filename also has to be enabled in Preferences/Multiplexer/Default values.