[RESOLVED] CLIP + cropping
Re: [RESOLVED] CLIP + cropping
OK, thank you. I have an idea what is going on. But please post your stream and screenshots so I can test my theory.
Re: [RESOLVED] CLIP + cropping
Here are screens
and video
https://dropmefiles.com/Po4vz
https://yadi.sk/i/8GaX8b-uEl3j1w
(One minute from Waterworld TV Cut without audio and subs).
If we open "cropping tool" in menu there's bottom crop 8 pixels already. To fix 1088 problem I guess. It seems it crops twice.
And there's another problem. With mkv. Coded size is always wrong. Height is always bigger then in "display size". Difference is that "bottom crop" in cropping tool. And video get cropped and stretched after dgsource.
and video
https://dropmefiles.com/Po4vz
https://yadi.sk/i/8GaX8b-uEl3j1w
(One minute from Waterworld TV Cut without audio and subs).
If we open "cropping tool" in menu there's bottom crop 8 pixels already. To fix 1088 problem I guess. It seems it crops twice.
And there's another problem. With mkv. Coded size is always wrong. Height is always bigger then in "display size". Difference is that "bottom crop" in cropping tool. And video get cropped and stretched after dgsource.
Re: [RESOLVED] CLIP + cropping
Thank you. Can you please test this revised version of DGDecodeNV.dll (64-bit)?
http://rationalqm.us/misc/DGDecodeNV_Keyser78.dll
http://rationalqm.us/misc/DGDecodeNV_Keyser78.dll
Re: [RESOLVED] CLIP + cropping
It works perfect now (Coded size in mkv is wrong but result is ok).
Note: I've been tested 32-bit version before.
Note: I've been tested 32-bit version before.
Re: [RESOLVED] CLIP + cropping
Good, thanks. Can you give me an MKV that you think shows wrong coded size? Coded size is an elementary stream thing, not a container thing, so being MKV should be irrelevant.
Re: [RESOLVED] CLIP + cropping
Yeah, I can confirm that 165 is kind of broken even if I don't touch internal crop at all. Output looks slightly stretched - http://screenshotcomparison.com/comparison/129757
PC: RTX 2070 | Ryzen R9 5950X (no OC) | 64 GB RAM
Notebook: RTX 4060 | Ryzen R9 7945HX | 32 GB RAM
Notebook: RTX 4060 | Ryzen R9 7945HX | 32 GB RAM
Re: [RESOLVED] CLIP + cropping
Sure, we know that 165 has issues. But does the fix I posted work for you? I want to slipstream it soon so a prompt reply will be appreciated. Thank you.
Re: [RESOLVED] CLIP + cropping
I tried this dll and got a Bad license. Double-checked my license file and it works fine with slipstream 161.
PC: RTX 2070 | Ryzen R9 5950X (no OC) | 64 GB RAM
Notebook: RTX 4060 | Ryzen R9 7945HX | 32 GB RAM
Notebook: RTX 4060 | Ryzen R9 7945HX | 32 GB RAM
Re: [RESOLVED] CLIP + cropping
You must have a copy of the license file in the same directory as DGDecodeNV.dll.
Re: [RESOLVED] CLIP + cropping
Hi.
I tried the dll and at least I can now crop in AvsPmod with the same values as before without any over/undercrop.
Not sure how else to test it.
renols
I tried the dll and at least I can now crop in AvsPmod with the same values as before without any over/undercrop.
Not sure how else to test it.
renols
Re: [RESOLVED] CLIP + cropping
That's great feedback, renols, thank you. I will release the fix now.
Re: [RESOLVED] CLIP + cropping
Here are
https://dropmefiles.com/IRyST
Coded size is 1280x544, I don't get why. Video is 1280x536. Sar is not set (default setting for hd x264 encodes).
Re: [RESOLVED] CLIP + cropping
Thank you for the stream sample. The .264 elementary stream declares a coded size of 544 and a display area of 536, so it is being reported correctly. 544 is mod 16 and 536 is not. The coded size must be an integral number of macroblocks. One thing I can do is to populate the display size in the Info dialog. It's absence could be a bug, I'll check.
Re: CLIP + cropping
I agree 1088 is autocrop to 1080 but once you set a crop value it will be based on 1088.
BTW something else is more frustating:
- on a 1088 steam with coded display area at 1080
- don't set any crop value
- just set both NVresize's values ("rh" & "rv")
Check the result with editor on the bottom of the frame.
The resize is done with the full frame size at 1088 and not the autocropped at 1080 !!! Causing frame distorsion.
Is this process normal ?
[Edit] using build 168
Re: [RESOLVED] CLIP + cropping
No, that is not normal. I will sort this out once and for all. Thanks for pointing it out.
Re: [RESOLVED] CLIP + cropping
OK, I'm going to bite the bullet and make cropping relative to the display size. The coded size is just a complication with no user relevance. If anyone objects speak now as I am about to light the afterburner.
Re: [RESOLVED] CLIP + cropping
If your solution could satisfy most users, your choice make sense.
Re: [RESOLVED] CLIP + cropping
I have DGIndexNV cropping converted to work relative to the display size. It wasn't as hard as I expected. Tomorrow I will convert DGDecodeNV and give y'all a test version.
Re: [RESOLVED] CLIP + cropping
Here is a 64-bit test version of DGIndexNV/DGDecodeNV. Everything is relative to the display area. So if you have a coded 1088 with display area 1080, you do not need a fixed bottom crop of 8. I tested it quite a bit and it seems to be fine, but I will await your feedback before I revise the documents and do a slipstream.
http://rationalqm.us/misc/DGDecNV_taz742.zip
http://rationalqm.us/misc/DGDecNV_taz742.zip
Re: [RESOLVED] CLIP + cropping
Thank you I'll test it tomorrow but before I've a question: is it problematic to use your dgdecode 64bit version with a 32bit version of avisynth+ ?
Re: [RESOLVED] CLIP + cropping
Yes, it is problematic. I have added the 32-bit binaries to the ZIP file.
Re: [RESOLVED] CLIP + cropping
Your fixed version work like a charm for me.
Tested on a sample coded 1088 with display area 1080:
- Cropping only -> OK
- Resize only-> OK
- Cropping with Resize -> OK
Tested on a sample coded 1088 with display area 1080:
- Cropping only -> OK
- Resize only-> OK
- Cropping with Resize -> OK
Re: [RESOLVED] CLIP + cropping
Great news! Thank you for your testing, and thank you again for the gentle push to make this change. If you get a chance, please also test Save BMP and Copy BMP in DGIndexNV to see if they properly honor the display area and cropping. Should be OK but it never hurts to have a second pair of eyes.
Re: [RESOLVED] CLIP + cropping
I confirm that [Save BMP] and [Copy BMP] in DGIndexNV properly honor the display area and cropping.
Re: [RESOLVED] CLIP + cropping
Great. Thank you, taz742. I will make a slipstream today.