Support forum for DG Tools

OK, thank you. I have an idea what is going on. But please post your stream and screenshots so I can test my theory.

Here are screens


and video
https://dropmefiles.com/Po4vz
https://yadi.sk/i/8GaX8b-uEl3j1w

(One minute from Waterworld TV Cut without audio and subs).

If we open "cropping tool" in menu there's bottom crop 8 pixels already. To fix 1088 problem I guess. It seems it crops twice.

And there's another problem. With mkv. Coded size is always wrong. Height is always bigger then in "display size". Difference is that "bottom crop" in cropping tool. And video get cropped and stretched after dgsource.

Thank you. Can you please test this revised version of DGDecodeNV.dll (64-bit)?

http://rationalqm.us/misc/DGDecodeNV_Keyser78.dll

It works perfect now (Coded size in mkv is wrong but result is ok).

Note: I've been tested 32-bit version before.

Good, thanks. Can you give me an MKV that you think shows wrong coded size? Coded size is an elementary stream thing, not a container thing, so being MKV should be irrelevant.

Yeah, I can confirm that 165 is kind of broken even if I don't touch internal crop at all. Output looks slightly stretched - http://screenshotcomparison.com/comparison/129757

Sure, we know that 165 has issues. But does the fix I posted work for you? I want to slipstream it soon so a prompt reply will be appreciated. Thank you.

I tried this dll and got a Bad license. Double-checked my license file and it works fine with slipstream 161.

You must have a copy of the license file in the same directory as DGDecodeNV.dll.

Hi.

I tried the dll and at least I can now crop in AvsPmod with the same values as before without any over/undercrop.

Not sure how else to test it.

renols

That's great feedback, renols, thank you. I will release the fix now.

admin wrote: ↑

Sat Feb 09, 2019 6:46 am

Good, thanks. Can you give me an MKV that you think shows wrong coded size? Coded size is an elementary stream thing, not a container thing, so being MKV should be irrelevant.

Here are

https://dropmefiles.com/IRyST

Coded size is 1280x544, I don't get why. Video is 1280x536. Sar is not set (default setting for hd x264 encodes).

Thank you for the stream sample. The .264 elementary stream declares a coded size of 544 and a display area of 536, so it is being reported correctly. 544 is mod 16 and 536 is not. The coded size must be an integral number of macroblocks. One thing I can do is to populate the display size in the Info dialog. It's absence could be a bug, I'll check.

gonca wrote: ↑

Fri Dec 07, 2018 5:27 pm

Did you mean to remove "Always Crop 1088 -> 1080"?
Edit, it still seems to crop to 1080

admin wrote: ↑

Fri Dec 07, 2018 5:50 pm

That option never made any sense so you can pretend that it is always on. There's no reason not to always honor the stream's coded display area.

I agree 1088 is autocrop to 1080 but once you set a crop value it will be based on 1088.
BTW something else is more frustating:
- on a 1088 steam with coded display area at 1080
- don't set any crop value
- just set both NVresize's values ("rh" & "rv")
Check the result with editor on the bottom of the frame.

The resize is done with the full frame size at 1088 and not the autocropped at 1080 !!! Causing frame distorsion.

Is this process normal ?

[Edit] using build 168

No, that is not normal. I will sort this out once and for all. Thanks for pointing it out.

OK, I'm going to bite the bullet and make cropping relative to the display size. The coded size is just a complication with no user relevance. If anyone objects speak now as I am about to light the afterburner.

If your solution could satisfy most users, your choice make sense.

I have DGIndexNV cropping converted to work relative to the display size. It wasn't as hard as I expected. Tomorrow I will convert DGDecodeNV and give y'all a test version.

Here is a 64-bit test version of DGIndexNV/DGDecodeNV. Everything is relative to the display area. So if you have a coded 1088 with display area 1080, you do not need a fixed bottom crop of 8. I tested it quite a bit and it seems to be fine, but I will await your feedback before I revise the documents and do a slipstream.

http://rationalqm.us/misc/DGDecNV_taz742.zip

Thank you I'll test it tomorrow but before I've a question: is it problematic to use your dgdecode 64bit version with a 32bit version of avisynth+ ?

Yes, it is problematic. I have added the 32-bit binaries to the ZIP file.

Your fixed version work like a charm for me.
Tested on a sample coded 1088 with display area 1080:
- Cropping only -> OK
- Resize only-> OK
- Cropping with Resize -> OK

Great news! Thank you for your testing, and thank you again for the gentle push to make this change. If you get a chance, please also test Save BMP and Copy BMP in DGIndexNV to see if they properly honor the display area and cropping. Should be OK but it never hurts to have a second pair of eyes.

I confirm that [Save BMP] and [Copy BMP] in DGIndexNV properly honor the display area and cropping.

Great. Thank you, taz742. I will make a slipstream today.