Page 1 of 1

[RESOLVED] EAC-3 7.1 in m2ts

Posted: Fri Feb 01, 2019 10:29 am
by Guest 2
I have some troubles when feeding DGIndexNV with a m2ts containing some E-AC3 audio, that is commonly used as a poor man version of 7.1 channel track.

I sent a small part by FTP as "First man.m2ts".

Please notice than when the whole m2ts is given to DGIndexNV, I get some PMT/PAT advice and, whatever the answer I give, I get badly recognized audio tracks.

With this partial chunk, you simply get badly recognized audio tracks with no notice.

Re: E-AC3 7.1 in m2ts

Posted: Fri Feb 01, 2019 11:21 am
by admin
Specifically, what do you mean by "badly recognized audio tracks"? I load the stream, hit F5, and I see the E-AC3 tracks listed in the info display. If I demux one of them it plays fine in MPC-HC.

Re: E-AC3 7.1 in m2ts

Posted: Fri Feb 01, 2019 1:18 pm
by Guest 2
admin wrote:
Fri Feb 01, 2019 11:21 am
Specifically, what do you mean by "badly recognized audio tracks"?
The audio tracks are (from MediaInfo):

Audio #1 Dolby TrueHD with Dolby Atmos 7.1 L R C LFE Ls Rs Lb Rb
Audio #2 E-AC-3 7.1 L R C LFE Ls Rs Lb Rb
Audio #3 E-AC-3 7.1 L R C LFE Ls Rs Lb Rb
Audio #4 E-AC-3 7.1 L R C LFE Ls Rs Lb Rb
Audio #5 AC-3 2.0 L R

DGIndexNV sees them as:

1100 THD (ok)
1101 E-AC3 3.2
1102 E-AC3 3.1
1103 E-AC3 3.2
1101 AC3 2.0

Plus if you open the complete stream (40GB) and not the single chunk it gives you the PAT/PMT mismatch error too.

Re: E-AC3 7.1 in m2ts

Posted: Fri Feb 01, 2019 6:13 pm
by admin
OK, thank you. Investigating...

Re: E-AC3 7.1 in m2ts

Posted: Tue Feb 05, 2019 4:51 pm
by admin
OK, I have to redesign my parser, as it was only looking at the first audio header. But for this stream you need to look at both the independent AC3 header and the EAC3 substream header. Also, I have to honor the chanmape flag in case a custom channel map is included, as it is for your stream.

This may take a while as redesigning the parser is a non-trivial thing and needs to be carefully thought through and implemented. Fortunately it's mainly cosmetic as demuxing is working fine.

Re: E-AC3 7.1 in m2ts

Posted: Tue Feb 12, 2019 8:32 pm
by admin
The parser is now re-designed as needed and is collecting all the correct fields from the AC3 core stream and the E-AC3 substream. The next step is to decode the rather obscure text in the A/52 specification to allow me to map the relevant fields to a proper channel description for the Info dialog and the demuxed file name. I've already got the sample rate and overall bitrate working (matching MediaInfo output); it's just the channel map I have left to figure out.

Re: E-AC3 7.1 in m2ts

Posted: Fri Feb 15, 2019 8:59 am
by Guest 2
admin wrote:
Tue Feb 12, 2019 8:32 pm
it's just the channel map I have left to figure out.
I know you like to dig thru strange things and I make my best to make your day :mrgreen:

If you need testing, tell me.

Re: E-AC3 7.1 in m2ts

Posted: Fri Feb 15, 2019 9:55 am
by admin
I'll definitely take up your testing offer when I have it ready. Thanks. I have the channel map worked out but now I get a wrong bitrate for some streams, so looking into that.

Re: E-AC3 7.1 in m2ts

Posted: Sat Feb 16, 2019 3:06 am
by Guest 2
admin wrote:
Fri Feb 15, 2019 9:55 am
I'll definitely take up your testing offer when I have it ready. Thanks. I have the channel map worked out but now I get a wrong bitrate for some streams, so looking into that.
While you are touching parsing, would you please consider the possibility to extract chapters from mpls and m2ts?

Re: E-AC3 7.1 in m2ts

Posted: Sat Feb 16, 2019 3:33 am
by DJATOM
If you need a mpls parser and chapter generator, I wrote some on python3: https://pastebin.com/VdW9LRSP. You will need pyqt5 in your python3 installation and probably some other dependencies, I don't remember.
Usage is simple: if you're making a chapters from vol.2, vol.3 or so, adjust counter in the right top corner of app. In the left corner you can set file name prefix.
Chapter files will be split based on mpls internal information. In my case Japanese blurays often have episodes separated, so mpls structure have marks for every m2ts file linked into playlist. I'm using that information to make separated chapter files. In case of single m2ts file it will make one or two files, depending on what we have linked into playlist.
Well, once GUI is configured, press Open and Write chapters, it will ask you to select source .mpls file and a folder for output chapters files.

Re: E-AC3 7.1 in m2ts

Posted: Tue Feb 26, 2019 12:35 pm
by admin
Let's consider Guest 2's additional feature request after we get the EAC3 detection fixed. Thanks DJATOM for your information about it.

Here is a 64-bit test version of DGIndexNV for the EAC3 detection fix. There may be a case where you get a popup asking to send me the stream. It covers a case that is unclear (to me) in the spec. Thank you for your testing.

http://rationalqm.us/misc/DGIndexNV_Guest 2.exe

Re: E-AC3 7.1 in m2ts

Posted: Tue Feb 26, 2019 6:03 pm
by admin
I discovered by looking for samples online that it does not work for EAC3 without AC3 core, such as in a DVB transport stream or HD-DVD. I am working on that. Works for me with bluray m2ts.

Re: E-AC3 7.1 in m2ts

Posted: Wed Feb 27, 2019 9:55 am
by admin
Please re-download as I have added proper support for streams without an AC3 core. I also removed the popup and added proper code for the unclear case I mentioned earlier. Hopefully, this build is now good to go.

http://rationalqm.us/misc/DGIndexNV_Guest 2.exe

Thank you for your testing.

Re: E-AC3 7.1 in m2ts

Posted: Thu Feb 28, 2019 10:59 am
by admin
Well, I'm feeling pretty confident about the changes as they are working fine on all the test files I have been able to find. I'll slipstream later today unless I hear from y'all of any test failures in the meantime.

Re: E-AC3 7.1 in m2ts

Posted: Mon Mar 04, 2019 3:08 am
by Guest 2
admin wrote:
Thu Feb 28, 2019 10:59 am
Well, I'm feeling pretty confident about the changes as they are working fine on all the test files I have been able to find. I'll slipstream later today unless I hear from y'all of any test failures in the meantime.
Late reply, I know but I have some health issues.

I will try on the same BD and tell you ASAP.

Thanks :)

EDIT: tested and works perfectly. On next iteration of parser, please consider chapter extraction too.

Re: [RESOLVED] EAC-3 7.1 in m2ts

Posted: Mon Mar 04, 2019 7:30 am
by admin
OK, thank you. Get well soon.

Re: [RESOLVED] EAC-3 7.1 in m2ts

Posted: Mon Mar 04, 2019 1:25 pm
by admin
I split off the chapter parser thing to a new thread. Please followup there.

viewtopic.php?f=8&t=710

Re: [RESOLVED] EAC-3 7.1 in m2ts

Posted: Sat Mar 16, 2019 7:42 am
by Guest 2
Just noticed that when demuxing eac3 from mkv, it doesn't append suffix .eac3

Can't remember if it did before or it is a regression.

Re: [RESOLVED] EAC-3 7.1 in m2ts

Posted: Sat Mar 16, 2019 12:08 pm
by admin
It's always been that way. Fix is easy and will be in the next slipstream. Thank you for pointing it out.