[RESOLVED] Seamless branching issues?

Support forum for DGDecNV
User avatar
Rocky
Posts: 408
Joined: Fri Sep 06, 2019 12:57 pm

Re: Seamless branching issues?

Post by Rocky » Fri Oct 04, 2019 1:19 pm

@gonca

Gotcha. Quite right.

The drive is an ASUS BC-12D2HT. Not sure what firmware it has, nor how to query that. It was pre-flashed by the vendor ClonerAlliance and advertised as "UHD friendly". That appears to be true. Nevertheless, MakeMKV says that the drive firmware is "not updated for LibreDrive". Seems to not matter; good enough for us.

@all

Extending M2TS file gaps processing to EAC3 was a tad harder than expected. You have to allow for the presence of an AC3 core, other substreams, and numblkscod (number of blocks per frame). I do have it working with the EAC3 streams from the Cars 2 disk.

So now we just need to consider the THD embedded AC3; everything else from the Cars 2 disk is in sync with the change just described. Looking into the embedded AC3 case now.

Let's first slipstream this EAC3 demux fix together with some improvements to the HDR to SDR dialog.

Meanwhile, very happy that we are beating EAC3TO for SUP file demuxing in this use case. 8-)

User avatar
Rocky
Posts: 408
Joined: Fri Sep 06, 2019 12:57 pm

Re: Seamless branching issues?

Post by Rocky » Fri Oct 04, 2019 1:36 pm

Just in case you are curious the current dinner plate includes the following delicacies:

1. Complete audio demuxing fixes stemming from renols's report (THD embedded AC3).
2. Fix an issue with DGIndexNV's handling of start codes split between transport packets (rare but we like to be fully correct and robust).
3. Implement 2390 target display scaling for PQ (EETF) in DGHDRtoSDR (and DGIndexNV), as pointed out by Bullwinkle.
4. Other things like export resize settings, free zoom in the GUI, etc.

Whee!

User avatar
Bullwinkle
Posts: 72
Joined: Thu Sep 05, 2019 6:37 pm

Re: Seamless branching issues?

Post by Bullwinkle » Fri Oct 04, 2019 2:23 pm

ha. people say I am correct and robust. snort!

all this drop audio frames nonsense is a fart of the you-know-what. repeat video frames when needed no BIG deal (repeat flags in the video ES duh). people call me a big deal get used to it.

wanna stick to the little deal then just map the embedded ac3 to an auxiliary audio[] entry you already know that. warts warts warts should I say whee?

even hoomans know audio interruptions are more startling than video ones

moose regards to culture lovers everywhere.

User avatar
Rocky
Posts: 408
Joined: Fri Sep 06, 2019 12:57 pm

Re: Seamless branching issues?

Post by Rocky » Fri Oct 04, 2019 4:19 pm

That's great, Bullwinkle, but only if all the audio streams need the same adjustment. Is that always true? And is it so easy to insert repeat flags?

User avatar
Bullwinkle
Posts: 72
Joined: Thu Sep 05, 2019 6:37 pm

Re: Seamless branching issues?

Post by Bullwinkle » Sat Oct 05, 2019 7:13 pm

Exercises are for students. The details. Move on. This is more EXCITING trigger warning!

https://www.youtube.com/watch?v=9xZdWhVQ4RU

Turn up the volume!!!

User avatar
Rocky
Posts: 408
Joined: Fri Sep 06, 2019 12:57 pm

Re: Seamless branching issues?

Post by Rocky » Tue Oct 08, 2019 11:56 am

Slipstream 189 now supports sync correction for EAC3 streams. Regarding the THD stream, I looked a bit at it and possibly what is happening is that the THD frames are smaller such that the file gap desyncs are too small to accumulate to the point of needing correction. I am looking into correcting the THD embedded AC3 now. If that gets done, then all the demuxed audio streams from Cars 2 will be properly synced to the video.

User avatar
Rocky
Posts: 408
Joined: Fri Sep 06, 2019 12:57 pm

Re: Seamless branching issues?

Post by Rocky » Fri Oct 18, 2019 7:57 pm

Doing gaps correction for THD embedded AC3 was much trickier than hoped. 10 days. :wow: But it is now working. The Cars 2 embedded AC3 is now demuxed in good sync. I want to do some regression testing and a bit of refactoring, then give y'all a slipstream.

User avatar
Bullwinkle
Posts: 72
Joined: Thu Sep 05, 2019 6:37 pm

Re: Seamless branching issues?

Post by Bullwinkle » Fri Oct 18, 2019 7:59 pm

Way to go Rock!

User avatar
Rocky
Posts: 408
Joined: Fri Sep 06, 2019 12:57 pm

Re: Seamless branching issues?

Post by Rocky » Sat Oct 19, 2019 10:25 am

Gaps processing for THD embedded AC3 demuxing now released in slipstream 190.

@renols

For me all the audio/subtitle streams in Cars 2 are now demuxed with proper sync to the demuxed video. Can we mark this thread resolved?

User avatar
hydra3333
Posts: 171
Joined: Wed Oct 06, 2010 3:34 am
Contact:

Re: Seamless branching issues?

Post by hydra3333 » Sat Oct 19, 2019 7:05 pm

:hat: :bravo: :)

Post Reply