[CLOSED] DGNV HDR preview doesn't match DGHDR2SDR results
Re: DGNV HDR preview doesn't match DGHDR2SDR results
I resemble that remark.
Curly Howard
Director of EAC3TO Development
Director of EAC3TO Development
Re: DGNV HDR preview doesn't match DGHDR2SDR results
Shaddap!
Tashie, don't feed the trolls.
Tashie, don't feed the trolls.
- Mr. Peabody
- Posts: 45
- Joined: Tue Dec 24, 2019 9:20 am
Re: DGNV HDR preview doesn't match DGHDR2SDR results
I'm not blind!
Re: DGNV HDR preview doesn't match DGHDR2SDR results
Sherman Peabody
Director of Linux Development
Director of Linux Development
Re: DGNV HDR preview doesn't match DGHDR2SDR results
Checked the code and the conversion is coded for 709 so Curly's theory appears incorrect. Still looking for the source of the discrepancy.
- Bullwinkle
- Posts: 338
- Joined: Thu Sep 05, 2019 6:37 pm
Re: DGNV HDR preview doesn't match DGHDR2SDR results
The kid did pretty good on the PVBob() issue. Why don't we assign him this one?
Re: DGNV HDR preview doesn't match DGHDR2SDR results
Thanks, Bullwinkle. I'll get right on it.
Sherman Peabody
Director of Linux Development
Director of Linux Development
Re: DGNV HDR preview doesn't match DGHDR2SDR results
I'm not seeing a problem here. First off, the ConvertToRGB() in the script is not needed and just complicates things. So I removed that. Also there's no need for doing F8 and all that. I used ColorPic to look at the pixels for 2 cases:
1. Directly in DGIndexNV display (not via F8).
2. Script loaded in VirtualDub2.
Below I show the results. You can see that the results are the same (allowing for different pixels and possible small algorithmic differences in the two display chains. On the left is DGIndexNV and on the right is Avisynth+VirtualDub2.
I also confirmed that there are no relevant code differences for the two conversions. I recommend closing this if MeteorRain is OK with that.
1. Directly in DGIndexNV display (not via F8).
2. Script loaded in VirtualDub2.
Below I show the results. You can see that the results are the same (allowing for different pixels and possible small algorithmic differences in the two display chains. On the left is DGIndexNV and on the right is Avisynth+VirtualDub2.
I also confirmed that there are no relevant code differences for the two conversions. I recommend closing this if MeteorRain is OK with that.
Sherman Peabody
Director of Linux Development
Director of Linux Development
Re: DGNV HDR preview doesn't match DGHDR2SDR results
You're right, boy, but the hullabaloo? In the debugger, directly compare the YUV values entering the RGB conversions.
Curly Howard
Director of EAC3TO Development
Director of EAC3TO Development
Re: DGNV HDR preview doesn't match DGHDR2SDR results
Don't we need an end-to-end test? Otherwise someone could say fine, the YUVs are the same, but the RGB conversion in DGIndexNV is messed up. It would be a useful double-check, I agree.
I think everything is just fine. Rocky
I think everything is just fine. Rocky
Sherman Peabody
Director of Linux Development
Director of Linux Development
Re: DGNV HDR preview doesn't match DGHDR2SDR results
Gonna close it then. Thank you, Sherman.
- MeteorRain
- Posts: 130
- Joined: Fri Jul 25, 2014 4:04 pm
- Location: New Jersey
Re: [CLOSED] DGNV HDR preview doesn't match DGHDR2SDR results
Thanks, I'll double check the colors.