[CLOSED] DGNV HDR preview doesn't match DGHDR2SDR results

Support forum for DGDecNV
Post Reply
User avatar
Curly
Posts: 712
Joined: Sun Mar 15, 2020 11:05 am

Re: DGNV HDR preview doesn't match DGHDR2SDR results

Post by Curly »

I resemble that remark. :evil:
Curly Howard
Director of EAC3TO Development
User avatar
Boris
Posts: 92
Joined: Sun Nov 10, 2019 2:55 pm

Re: DGNV HDR preview doesn't match DGHDR2SDR results

Post by Boris »

Shaddap!
Tashie, don't feed the trolls.
User avatar
Mr. Peabody
Posts: 45
Joined: Tue Dec 24, 2019 9:20 am

Re: DGNV HDR preview doesn't match DGHDR2SDR results

Post by Mr. Peabody »

Rocky wrote:
Sun Mar 29, 2020 8:44 pm
Fortunately it's only a display issue in DGIndexNV GUI.
However, it's unfortunate to the extent that using DGIndexNV to find good DGHDRtoSDR() parameters is now problematic.
User avatar
Rocky
Posts: 3556
Joined: Fri Sep 06, 2019 12:57 pm

Re: DGNV HDR preview doesn't match DGHDR2SDR results

Post by Rocky »

I'm not blind!
User avatar
Sherman
Posts: 576
Joined: Mon Jan 06, 2020 10:19 pm

Re: DGNV HDR preview doesn't match DGHDR2SDR results

Post by Sherman »

Mr. Peabody, could this be the girl for you?

https://www.youtube.com/watch?time_cont ... u3HN-MmJc4
Sherman Peabody
Director of Linux Development
User avatar
Rocky
Posts: 3556
Joined: Fri Sep 06, 2019 12:57 pm

Re: DGNV HDR preview doesn't match DGHDR2SDR results

Post by Rocky »

Checked the code and the conversion is coded for 709 so Curly's theory appears incorrect. Still looking for the source of the discrepancy.
User avatar
Bullwinkle
Posts: 338
Joined: Thu Sep 05, 2019 6:37 pm

Re: DGNV HDR preview doesn't match DGHDR2SDR results

Post by Bullwinkle »

The kid did pretty good on the PVBob() issue. Why don't we assign him this one?
User avatar
Sherman
Posts: 576
Joined: Mon Jan 06, 2020 10:19 pm

Re: DGNV HDR preview doesn't match DGHDR2SDR results

Post by Sherman »

Thanks, Bullwinkle. I'll get right on it.
Sherman Peabody
Director of Linux Development
User avatar
Sherman
Posts: 576
Joined: Mon Jan 06, 2020 10:19 pm

Re: DGNV HDR preview doesn't match DGHDR2SDR results

Post by Sherman »

I'm not seeing a problem here. First off, the ConvertToRGB() in the script is not needed and just complicates things. So I removed that. Also there's no need for doing F8 and all that. I used ColorPic to look at the pixels for 2 cases:

1. Directly in DGIndexNV display (not via F8).

2. Script loaded in VirtualDub2.

Below I show the results. You can see that the results are the same (allowing for different pixels and possible small algorithmic differences in the two display chains. On the left is DGIndexNV and on the right is Avisynth+VirtualDub2.

ImageImage

I also confirmed that there are no relevant code differences for the two conversions. I recommend closing this if MeteorRain is OK with that.
Sherman Peabody
Director of Linux Development
User avatar
Curly
Posts: 712
Joined: Sun Mar 15, 2020 11:05 am

Re: DGNV HDR preview doesn't match DGHDR2SDR results

Post by Curly »

You're right, boy, but the hullabaloo? :roll: In the debugger, directly compare the YUV values entering the RGB conversions.

Image
Curly Howard
Director of EAC3TO Development
User avatar
Sherman
Posts: 576
Joined: Mon Jan 06, 2020 10:19 pm

Re: DGNV HDR preview doesn't match DGHDR2SDR results

Post by Sherman »

Don't we need an end-to-end test? Otherwise someone could say fine, the YUVs are the same, but the RGB conversion in DGIndexNV is messed up. It would be a useful double-check, I agree.

I think everything is just fine. :salute: Rocky
Sherman Peabody
Director of Linux Development
User avatar
Rocky
Posts: 3556
Joined: Fri Sep 06, 2019 12:57 pm

Re: DGNV HDR preview doesn't match DGHDR2SDR results

Post by Rocky »

Gonna close it then. Thank you, Sherman.
User avatar
MeteorRain
Posts: 130
Joined: Fri Jul 25, 2014 4:04 pm
Location: New Jersey

Re: [CLOSED] DGNV HDR preview doesn't match DGHDR2SDR results

Post by MeteorRain »

Thanks, I'll double check the colors.
Post Reply