Page 1 of 1

Re: DGNV HDR preview doesn't match DGHDR2SDR results

Posted: Sun Mar 29, 2020 9:02 pm
by Curly
I resemble that remark. :evil:

Re: DGNV HDR preview doesn't match DGHDR2SDR results

Posted: Sun Mar 29, 2020 9:03 pm
by Boris
Shaddap!
Tashie, don't feed the trolls.

Re: DGNV HDR preview doesn't match DGHDR2SDR results

Posted: Sun Mar 29, 2020 9:20 pm
by Mr. Peabody
Rocky wrote:
Sun Mar 29, 2020 8:44 pm
Fortunately it's only a display issue in DGIndexNV GUI.
However, it's unfortunate to the extent that using DGIndexNV to find good DGHDRtoSDR() parameters is now problematic.

Re: DGNV HDR preview doesn't match DGHDR2SDR results

Posted: Sun Mar 29, 2020 9:22 pm
by Rocky
I'm not blind!

Re: DGNV HDR preview doesn't match DGHDR2SDR results

Posted: Sun Mar 29, 2020 9:43 pm
by Sherman
Mr. Peabody, could this be the girl for you?

https://www.youtube.com/watch?time_cont ... u3HN-MmJc4

Re: DGNV HDR preview doesn't match DGHDR2SDR results

Posted: Mon Mar 30, 2020 10:00 am
by Rocky
Checked the code and the conversion is coded for 709 so Curly's theory appears incorrect. Still looking for the source of the discrepancy.

Re: DGNV HDR preview doesn't match DGHDR2SDR results

Posted: Wed May 06, 2020 8:26 am
by Bullwinkle
The kid did pretty good on the PVBob() issue. Why don't we assign him this one?

Re: DGNV HDR preview doesn't match DGHDR2SDR results

Posted: Wed May 06, 2020 8:27 am
by Sherman
Thanks, Bullwinkle. I'll get right on it.

Re: DGNV HDR preview doesn't match DGHDR2SDR results

Posted: Wed May 06, 2020 10:05 am
by Sherman
I'm not seeing a problem here. First off, the ConvertToRGB() in the script is not needed and just complicates things. So I removed that. Also there's no need for doing F8 and all that. I used ColorPic to look at the pixels for 2 cases:

1. Directly in DGIndexNV display (not via F8).

2. Script loaded in VirtualDub2.

Below I show the results. You can see that the results are the same (allowing for different pixels and possible small algorithmic differences in the two display chains. On the left is DGIndexNV and on the right is Avisynth+VirtualDub2.

ImageImage

I also confirmed that there are no relevant code differences for the two conversions. I recommend closing this if MeteorRain is OK with that.

Re: DGNV HDR preview doesn't match DGHDR2SDR results

Posted: Wed May 06, 2020 12:55 pm
by Curly
You're right, boy, but the hullabaloo? :roll: In the debugger, directly compare the YUV values entering the RGB conversions.

Image

Re: DGNV HDR preview doesn't match DGHDR2SDR results

Posted: Wed May 06, 2020 1:10 pm
by Sherman
Don't we need an end-to-end test? Otherwise someone could say fine, the YUVs are the same, but the RGB conversion in DGIndexNV is messed up. It would be a useful double-check, I agree.

I think everything is just fine. :salute: Rocky

Re: DGNV HDR preview doesn't match DGHDR2SDR results

Posted: Fri May 08, 2020 1:47 pm
by Rocky
Gonna close it then. Thank you, Sherman.

Re: [CLOSED] DGNV HDR preview doesn't match DGHDR2SDR results

Posted: Fri May 08, 2020 7:00 pm
by MeteorRain
Thanks, I'll double check the colors.