[RESOLVED] Issue with Jerry Maguire THD stream

Support forum for DGDecNV
User avatar
Rocky
Posts: 3555
Joined: Fri Sep 06, 2019 12:57 pm

Re: Issue with Jerry Maguire THD stream

Post by Rocky »

Here is a test version with MVC and the THD fix.

http://rationalqm.us/dgdemux/binaries/D ... c_test.rar

Feedback will be appreciated.
User avatar
Sherman
Posts: 576
Joined: Mon Jan 06, 2020 10:19 pm

Re: Issue with Jerry Maguire THD stream

Post by Sherman »

Rocky wrote:
Sun Jun 28, 2020 8:48 am
I figured all that buffering and parsing was going to be a PITA, so I was happy when you offered to fix this. ;) That you found a better way is frosting on the cake.
Thanks, Rocky. My way also has the advantage that when gaps processing is not required (it's disabled or there is only one M2TS) the demuxing is somewhat faster. To be honest, buffering and parsing at different levels is a real performance killer. Yes, I know DGIndexNV is designed that way, but it almost has to be that way as the relation between the video and everything else is very important and must be maintained, especially to honor the project range, etc. But for DGDemux we should be able to get rid of all that. I see you started implementing my way and got a giant performance boost (350%). I can finish that off if you like.
Sherman Peabody
Director of Linux Development
User avatar
Rocky
Posts: 3555
Joined: Fri Sep 06, 2019 12:57 pm

Re: Issue with Jerry Maguire THD stream

Post by Rocky »

Go for it, Sherman!

My life has become so easy. :lol:

Bullwinkle: ace system architect and forum enforcer
Sherman: ace coder and apprentice system architect
Rocky: ace debugger and occasional coder
Curly: our conscience
Levi: spiritual and creative foundation
admin: bean counter
DG: founder and benefactor
DAE avatar
Guest

Re: Issue with Jerry Maguire THD stream

Post by Guest »

Quick test
Movie with one M2TS and 0 ms delay between audio and video
video 1 h 48 min 54 s 243 ms
thd... 1 h 48 min 54 s 237 ms
ac3... 1 h 48 min 54 s 240 ms
User avatar
Bullwinkle
Posts: 338
Joined: Thu Sep 05, 2019 6:37 pm

Re: Issue with Jerry Maguire THD stream

Post by Bullwinkle »

Sherman! C'mon, you can't do gaps correction when the stream is not enabled for demuxing. Otherwise, highly impressive.

@gonca

Thank you for your testing. Looking good.
User avatar
Sherman
Posts: 576
Joined: Mon Jan 06, 2020 10:19 pm

Re: Issue with Jerry Maguire THD stream

Post by Sherman »

Bullwinkle wrote:
Sun Jun 28, 2020 10:16 am
you can't do gaps correction when the stream is not enabled for demuxing
Oh, yeah, thanks. I'll give Rocky an update and he can update the test version.
Sherman Peabody
Director of Linux Development
User avatar
Rocky
Posts: 3555
Joined: Fri Sep 06, 2019 12:57 pm

Re: Issue with Jerry Maguire THD stream

Post by Rocky »

Sherman wrote:
Sun Jun 28, 2020 10:18 am
I'll give Rocky an update and he can update the test version.
Test version updated online.
DAE avatar
renols
Posts: 149
Joined: Tue Feb 22, 2011 2:34 am

Re: Issue with Jerry Maguire THD stream

Post by renols »

Hi.

Have given the test version a run.

Jerry Maguire. The thd file is now binary compared the same as the old dgdemux version with gap disabled. So disabling gap is no longer needed to get a good thd file.

Cars 2. The file created by dgdemux test version and dgindexnv (210) is binary compared the same, and comparing flac audio run time to video runtime shows only a difference of 9 ms.

On Cars 2 the dgdemux test version spends some time on "THD Gap fixing", but guess that is how it is supposed to be, when doing the fixing at the end rather than on the fly. Wether it is faster than what dgindexnv (210) does I don't know.

renols
User avatar
Sherman
Posts: 576
Joined: Mon Jan 06, 2020 10:19 pm

Re: Issue with Jerry Maguire THD stream

Post by Sherman »

Hello Mr renols. We haven't met but I have heard wonderful things about you. Great that you found no issues. Theoretically, the new way is faster in all use cases. However, that is moot as we move to the new 350% faster architecture.
Sherman Peabody
Director of Linux Development
User avatar
Rocky
Posts: 3555
Joined: Fri Sep 06, 2019 12:57 pm

Re: [RESOLVED] Issue with Jerry Maguire THD stream

Post by Rocky »

Was reviewing old threads for marking RESOLVED. Just wanted to add here that renols was correct about the fixing process being very slow. Fortunately, Sherman repaired that not too long ago. The process for a typical disk was reduced from 60 seconds to 3 seconds. He's a good boy.
Post Reply