DGDemux development

User avatar
Bullwinkle
Moose Approved
Posts: 180
Joined: Thu Sep 05, 2019 6:37 pm

Re: DGDemux development

Post by Bullwinkle »

Nice work. I found some issues doing MONSTERS_UNIVERSITY:

1. The fast video stream is missing a single byte at the end (weird!).

2. The THD embedded AC3 doesn't match.

3. The SUPs don't match.

BTW, I tested slow mode in the test version versus build 43 and everything matched.
User avatar
Sherman
Moose Approved
Posts: 136
Joined: Mon Jan 06, 2020 10:19 pm

Re: DGDemux development

Post by Sherman »

Thanks, Bullwinkle. I'll fix that up ASAP.
User avatar
Sherman
Moose Approved
Posts: 136
Joined: Mon Jan 06, 2020 10:19 pm

Re: DGDemux development

Post by Sherman »

I fixed the SUP and embedded AC3 demuxing in fast mode. The video discrepancy is actually the old architecture outputing an extra spurious byte at the end of the stream. The fast mode is correct and EAC3TO also doesn't output that byte. I'll do some testing and then give an update for the fast mode test build.

I also fixed a problem with DGDemuxGUI. It was not showing the 'Fix THD gaps' message.
User avatar
Bullwinkle
Moose Approved
Posts: 180
Joined: Thu Sep 05, 2019 6:37 pm

Re: DGDemux development

Post by Bullwinkle »

Keep it up Sherman, you're doing great. Apart from the one-byte video difference MONSTERS demuxes identically between slow and fast modes.

Can you check a few more things, please:

* Proper operation of the skip options in fast mode.
* The FixTHDGaps() function seems slow but maybe it is what it is.

Also, don't forget to implement garbage stripping, and AVC filler NALU stripping (if possible).
User avatar
Sherman
Moose Approved
Posts: 136
Joined: Mon Jan 06, 2020 10:19 pm

Re: DGDemux development

Post by Sherman »

Will do, Bullwinkle. Thank you for your testing.

Meanwhile, here is an updated fast mode build with the aforementioned fixes:

http://rationalqm.us/dgdemux/binaries/D ... t_test.rar

* Fixed SUP demuxing (it was broken only for multiple M2TS files in the playlist).
* Fixed THD embedded AC3 demuxing (gaps correction was not being performed).
* Fixed missing 'Fix THD gaps' message in the GUI.
User avatar
gonca
Curly Approved/Moose Approved
Posts: 956
Joined: Sun Apr 08, 2012 6:12 pm

Re: DGDemux development

Post by gonca »

Gonna copy some movies from my archive and will try to test today
User avatar
Sherman
Moose Approved
Posts: 136
Joined: Mon Jan 06, 2020 10:19 pm

Re: DGDemux development

Post by Sherman »

Sweet. Thank you, gonca. Would be great if you can test a 3D disk, demuxing all streams and just the MVC stream.
User avatar
gonca
Curly Approved/Moose Approved
Posts: 956
Joined: Sun Apr 08, 2012 6:12 pm

Re: DGDemux development

Post by gonca »

Copying one of those as well
User avatar
gonca
Curly Approved/Moose Approved
Posts: 956
Joined: Sun Apr 08, 2012 6:12 pm

Re: DGDemux development

Post by gonca »

Gonna report one disc at a time so my head doesn't explode from the data

VENOM 4K
Primary video in slow is one byte bigger than fast
All other tracks, including DV and PGS, are identical

BUMBLEBEE 4K
Had to use no preallocation
Too many streams and preallocation was using up all free space and then some

One byte issue (I realize it might no be an issue but still reporting)
DV matches
Embedded AC3 matches
all other files match

VENOM 1080p
Size mismatch on AVC file
ac3 files match
PGS files match
can't open dts files

BUMBLEBEE 1080p
AVC made file compare go nuts
all other files match

AGE OF EXTINCTION 3D
AVC file made it go nuts again
*.tag files could not be opened
everything else matches

MVC only
match
User avatar
Rocky
Moose Approved
Posts: 1201
Joined: Fri Sep 06, 2019 12:57 pm

Re: DGDemux development

Post by Rocky »

That's fine. Maybe edit the post instead of making a new post for every disk?
User avatar
Rocky
Moose Approved
Posts: 1201
Joined: Fri Sep 06, 2019 12:57 pm

Re: DGDemux development

Post by Rocky »

:salute: for your edit

Can you provide purchase links for the last 3 disks? Thank you.

Also please report only issues. You don't have to mention what works. ;)

Finally, 'go nuts' is vague.
User avatar
gonca
Curly Approved/Moose Approved
Posts: 956
Joined: Sun Apr 08, 2012 6:12 pm

Re: DGDemux development

Post by gonca »

Can you provide purchase links for the last 3 disks?
You mean the 1080p ones?
Venom and Bumblebee were part the 4K set but the blu-ray should be the same

https://www.amazon.ca/Venom-Blu-ray-Bil ... dvd&sr=1-3
https://www.amazon.ca/Bumblebee-Blu-ray ... dvd&sr=1-3
https://www.amazon.ca/Transformers-Age- ... dvd&sr=1-2
Size mismatch is the one byte issue
'go nuts'
Large output from fc due to the filler NALUs
User avatar
Rocky
Moose Approved
Posts: 1201
Joined: Fri Sep 06, 2019 12:57 pm

Re: DGDemux development

Post by Rocky »

All right, Sherman has fixed the DTS.

Ah, I see, the tags files are not generated at all!

OK, I think we're good to go. No further clarification needed.
User avatar
Rocky
Moose Approved
Posts: 1201
Joined: Fri Sep 06, 2019 12:57 pm

Re: DGDemux development

Post by Rocky »

OK, please re-download the test build. The DTS and tags issues should be fixed. Please advise any further issues you find.

Greatly appreciate your testing, gonca!
User avatar
gonca
Curly Approved/Moose Approved
Posts: 956
Joined: Sun Apr 08, 2012 6:12 pm

Re: DGDemux development

Post by gonca »

The DTS and tags issue is fixed but something else popped up
issue.png
Please note the different delays on the same files
I'll retest if you wish
It was the Venom 1080p disc
By the way
If you like the transformer movies you would probably like Bumblebee
Edit 1
Mediainfo and MKVToolNIX report delay of 0ms which agrees with the slow demux
Edit 2
If you want me to test more discs let me know
User avatar
Rocky
Moose Approved
Posts: 1201
Joined: Fri Sep 06, 2019 12:57 pm

Re: DGDemux development

Post by Rocky »

I'll probably have to buy it because I can't duplicate that. I'll compare the code closely to see how a discrepancy like that could happen.

However, I was thinking of getting rid of the DELAY anyway as it should always be 0. Have you ever seen a non-zero value when demuxing slow or with EAC3TO? DGDecNV has to do it because you can set your range such that the project doesn't begin at the start of the first M2TS.

Great to hear DTS and tags are working!
User avatar
gonca
Curly Approved/Moose Approved
Posts: 956
Joined: Sun Apr 08, 2012 6:12 pm

Re: DGDemux development

Post by gonca »

I don't remember seeing any non zero delays in BDs
If it helps these are DTS HD-MA tracks
User avatar
Rocky
Moose Approved
Posts: 1201
Joined: Fri Sep 06, 2019 12:57 pm

Re: DGDemux development

Post by Rocky »

OK, thank you. I'll check all my disks and if there are no non-zero delays in slow mode then bye-bye DELAY! Sherman is back in 1935 but I think I can handle it.
User avatar
gonca
Curly Approved/Moose Approved
Posts: 956
Joined: Sun Apr 08, 2012 6:12 pm

Re: DGDemux development

Post by gonca »

One more thing
delay.png
This time I kept all the audio for comparison
In the slow demux the ac3 are all -8ms delay and the dts is 0 ms
In the fast demux they are listed as -8 ms
Is it possible the fast demux is somehow using the delay for the ac3 files and applying it to the dts files?
User avatar
gonca
Curly Approved/Moose Approved
Posts: 956
Joined: Sun Apr 08, 2012 6:12 pm

Re: DGDemux development

Post by gonca »

I realize that you are considering removing delay reporting but I decided to run some quick tests to try and narrow this down.
My regular demux >> Video + Primary eng audio (DTS HD-MA in this case) + eng subtitles
Delays match between slow and fast

Primary eng audio
Delays match

Demux both DTS HD-MA tracks
Delays match

Demux both DTS HD-MA tracks + any ac3 track
Delays don't match
It is as if the ac3 delay is being copied over

It might just be one of those once in a blue moon things
User avatar
Rocky
Moose Approved
Posts: 1201
Joined: Fri Sep 06, 2019 12:57 pm

Re: DGDemux development

Post by Rocky »

OK, thank you. I'll check it out.
User avatar
gonca
Curly Approved/Moose Approved
Posts: 956
Joined: Sun Apr 08, 2012 6:12 pm

Re: DGDemux development

Post by gonca »

Tried 3 more movies with similar dts and ac3 track mixtures
If only dts is demuxed then the delays match
If only ac3 is demuxed then the delays match
If dts and ac3 are both demuxed slow seems to have the correct delays, but in fast demux the dts tracks are assigned the delay values of the ac3 tracks
User avatar
Rocky
Moose Approved
Posts: 1201
Joined: Fri Sep 06, 2019 12:57 pm

Re: DGDemux development

Post by Rocky »

Yes, thank you. I'll release a fix tomorrow. Your theory is correct. ;)
User avatar
Sherman
Moose Approved
Posts: 136
Joined: Mon Jan 06, 2020 10:19 pm

Re: DGDemux development

Post by Sherman »

Just popping in to say it's looking possible to get Albert to join the forum. He wants some assurances about not allowing stupid people in here. I said, other than Natasha, should be no problem. And he wants immediate Moose or Britney Approval. ;)

Great job Rocky on the fast mode. Going back down. Wish me luck...
User avatar
Bullwinkle
Moose Approved
Posts: 180
Joined: Thu Sep 05, 2019 6:37 pm

Re: DGDemux development

Post by Bullwinkle »

Stop it, Sherman! You'll make me project from my second stomach. Honorary stomping award coming your way. Bring Albert back with you and you could be Moose Lodge material. Of course he can have whatever approval he wants.
Post Reply